-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC Update website to pydata-sphinx-theme
#29035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…into new_web_theme
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
…es (scikit-learn#28623) Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
@Charlie-XIAO you probably want to have a PR merging main repo's |
I was somehow trying to avoid myself accidentally messing up the main branch after I got the access 🤣 but okay I will reopen the PR from there. |
😆 yeah opening such PRs can be scary. I personally have a separate clone locally which has write access to the main repo (my usual clone doesn't), to make it a bit more conscious when dealing with such PRs. |
Note that you don't have to do anything locally in this regard though. You can do everything through PRs to the |
So essentially I should open a final cleanup PR targeting the |
The merging would also be through a PR, I opened it here: #29038, feel free to take over the PR. Once we're happy with the state of the |
Thank you so much! |
Reference Issues/PRs
Closes #28084. WIP.