Skip to content

FIX always return None as device when array API dispatch is disabled #29119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2024
Merged

FIX always return None as device when array API dispatch is disabled #29119

merged 3 commits into from
May 28, 2024

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented May 27, 2024 •
edited
Loading

Fixes #29107.

I manually checked that it fixes the problem described in the original report. I think the new unit test is good enough as non-regression test.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 9dbf05f. Link to the linter CI: here

@ogrisel ogrisel mentioned this pull request May 27, 2024
Closed
@ogrisel ogrisel added this to the 1.5.1 milestone May 27, 2024
@ogrisel ogrisel added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label May 27, 2024
OmarManzoor
OmarManzoor approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ogrisel

@OmarManzoor OmarManzoor merged commit 78102fd into scikit-learn:main May 28, 2024
31 checks passed
@jph00
Copy link

jph00 commented May 28, 2024

Thank you @ogrisel ! :D

jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request Jul 2, 2024
@ogrisel @jeremiedbb
FIX always return None as device when array API dispatch is disabled (s…
ea121c3 
…cikit-learn#29119)
@jeremiedbb jeremiedbb mentioned this pull request Jul 2, 2024
Merged
11 tasks
jeremiedbb pushed a commit that referenced this pull request Jul 2, 2024
@ogrisel @jeremiedbb
FIX always return None as device when array API dispatch is disabled (#…
a4b14cb 
…29119)
@ogrisel ogrisel deleted the fix-r2_score-on-torch-cpu-tensors branch December 10, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@OmarManzoor OmarManzoor OmarManzoor approved these changes

Assignees
No one assigned
Labels
module:utils To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.

Incorrect invalid device error introduced in #25956
4 participants
@ogrisel @jph00 @thomasjpfan @OmarManzoor