-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC add link to plot_ransac example in _ransac #29636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marenwestermann
requested changes
Aug 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment, otherwise LGTM.
marenwestermann
requested changes
Aug 17, 2024
sklearn/linear_model/_ransac.py
Outdated
@@ -89,6 +89,9 @@ class RANSACRegressor( | |||
RANSAC is an iterative algorithm for the robust estimation of parameters | |||
from a subset of inliers from the complete data set. | |||
|
|||
For a better understanding see example, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put this at the end of the "Examples" section and write "For a more detailed example, see ..."
marenwestermann
approved these changes
Aug 17, 2024
…nto doc/ransac
adrinjalali
approved these changes
Aug 21, 2024
MarcBresson
pushed a commit
to MarcBresson/scikit-learn
that referenced
this pull request
Sep 2, 2024
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 9, 2024
glemaitre
pushed a commit
that referenced
this pull request
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Documentation
module:linear_model
Waiting for Second Reviewer
First reviewer is done, need a second one!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#26927
What does this implement/fix? Explain your changes.
I have added the link to the examples/linear_model/plot_ransac.py example to the sklearn/linear_model/_ransac.py file for the RansacRegressor class.