Skip to content

DOC add link to plot_ransac example in _ransac #29636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

tusharparimi
Copy link
Contributor

Reference Issues/PRs

#26927

What does this implement/fix? Explain your changes.

I have added the link to the examples/linear_model/plot_ransac.py example to the sklearn/linear_model/_ransac.py file for the RansacRegressor class.

Copy link

github-actions bot commented Aug 7, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 69ae034. Link to the linter CI: here

Copy link
Member

@marenwestermann marenwestermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment, otherwise LGTM.

@@ -89,6 +89,9 @@ class RANSACRegressor(
RANSAC is an iterative algorithm for the robust estimation of parameters
from a subset of inliers from the complete data set.

For a better understanding see example,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put this at the end of the "Examples" section and write "For a more detailed example, see ..."

@marenwestermann marenwestermann added the Waiting for Second Reviewer First reviewer is done, need a second one! label Aug 17, 2024
@adrinjalali adrinjalali merged commit f977661 into scikit-learn:main Aug 21, 2024
33 checks passed
MarcBresson pushed a commit to MarcBresson/scikit-learn that referenced this pull request Sep 2, 2024
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants