Skip to content

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Oct 2, 2024

Fix #29781

Together with adding scikit-learn-bot to the Contributor Experience (aka Triage) team.

Copy link

github-actions bot commented Oct 2, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: a5cc9a9. Link to the linter CI: here

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ogrisel
Copy link
Member

ogrisel commented Oct 4, 2024

/cc @betatim @thomasjpfan

@thomasjpfan
Copy link
Member

@lesteve Are we going to special case the bot in https://github.com/scikit-learn/scikit-learn/blob/main/build_tools/generate_authors_table.py#L48 to make sure it does not appear in https://scikit-learn.org/stable/about.html ?

Copy link
Member

@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

+1 to Thomas' suggestion of special casing, but could do that in a new PR as well

@lesteve
Copy link
Member Author

lesteve commented Oct 7, 2024

As mentioned in #29781 (comment) I created a "Triage robots" team and added scikit-learn bot to it, so I am going to merge this one.

@lesteve lesteve merged commit 3d1746e into scikit-learn:main Oct 7, 2024
33 checks passed
@lesteve lesteve deleted the use-pat-token-in-bot-labeling branch October 7, 2024 09:42
BenJourdan pushed a commit to gregoryschwartzman/scikit-learn that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI CUDA CI not running in lock-file update automated PR
4 participants