-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
MAINT Handle deprecation of sokalmichener metric #30004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT Handle deprecation of sokalmichener metric #30004
Conversation
I don't think we added a changelog entry for similar cases in the past. The scikit-learn code does not really change as long as we do not drop support for scipy versions that removed some deprecated metrics (at which point we should deprecate the scikit-learn counterpart). |
Or shall we deprecate the scikit-learn counterparts right away, even? If so, we would need a changelog entry. For could do so in a follow-up PR to keep this PR minimal and fix scipy-dev CI asap. If we go the deprecation route, we can deprecate the 3 scipy metrics at once ( |
The coverage is of the diff of this PR is expected to be low. I think this is ready to review. /cc @lesteve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that we already have one metric deprecated :)
I think that we can merge this PR as is. Then, we can make another PR to announce the deprecation of |
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Closes #29925, #29995.