Skip to content

MAINT Handle deprecation of sokalmichener metric #30004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Oct 3, 2024

Closes #29925, #29995.

@ogrisel ogrisel changed the title Handle deprecation of sokalmichener metric MAINT Handle deprecation of sokalmichener metric Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 748bc68. Link to the linter CI: here

@ogrisel
Copy link
Member Author

ogrisel commented Oct 3, 2024

I don't think we added a changelog entry for similar cases in the past. The scikit-learn code does not really change as long as we do not drop support for scipy versions that removed some deprecated metrics (at which point we should deprecate the scikit-learn counterpart).

@ogrisel
Copy link
Member Author

ogrisel commented Oct 3, 2024

Or shall we deprecate the scikit-learn counterparts right away, even? If so, we would need a changelog entry.

For could do so in a follow-up PR to keep this PR minimal and fix scipy-dev CI asap.

If we go the deprecation route, we can deprecate the 3 scipy metrics at once (matching, kulsinski and sokalmichener).

@ogrisel ogrisel requested a review from thomasjpfan October 3, 2024 15:49
@ogrisel
Copy link
Member Author

ogrisel commented Oct 4, 2024

The coverage is of the diff of this PR is expected to be low. I think this is ready to review.

/cc @lesteve

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

glemaitre and others added 2 commits October 8, 2024 18:55
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that we already have one metric deprecated :)

@glemaitre
Copy link
Member

I think that we can merge this PR as is. Then, we can make another PR to announce the deprecation of SokalMichenerDistance and ask people to use RogersTanimotoDistance instead.

@glemaitre glemaitre enabled auto-merge (squash) October 8, 2024 17:22
@glemaitre glemaitre merged commit af57108 into scikit-learn:main Oct 8, 2024
28 checks passed
@ogrisel ogrisel deleted the handle-deprecation-of-sokalmichener-metric branch October 9, 2024 08:14
BenJourdan pushed a commit to gregoryschwartzman/scikit-learn that referenced this pull request Oct 11, 2024
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sokalmichener from distance metrics
3 participants