Skip to content

DOC: Update install instructions to recommend conda-forge over Anaconda #30626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Maddouchhamza
Copy link

@Maddouchhamza Maddouchhamza commented Jan 12, 2025

Reference Issues/PRs

Follow-up of #30193 with the goal of having a smaller scope.

What does this implement/fix? Explain your changes.

This Pull Request updates the Installing the latest release section of the documentation to recommend conda-forge as the preferred installation method for scikit-learn. Changes include:

  • Highlighting the advantages of using conda-forge for dependency management and cross-platform compatibility.
  • Making minimal changes to ensure the scope of this PR is focused and easy to review.

Any other comments?

I have tested the updated documentation locally using make doc and confirmed that it builds without warnings or errors. Please let me know if there are additional adjustments or improvements required. Thank you for your guidance and feedback throughout this process!

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 7e8711d. Link to the linter CI: here

@StefanieSenger
Copy link
Contributor

Thanks for the new PR @Maddouchhamza, we appreciate your efforts.

I would leave "For most users," away, because it keeps users guessing, if they are skilled enough to pick another route as recommended for most users.

We are trying to be approachable for a broad audience.

For instance, people graduating from a Data Science Bootcamp might only know one package manager which is not conda.

@lesteve
Copy link
Member

lesteve commented Jan 16, 2025

@Maddouchhamza thanks for creating a new PR with a reduced scope 🙏!

I would suggest the following:

  • remove mentions of Anaconda i.e. the full "Anaconda and Enthought Deployment Manager for all supported platforms" section
  • do not add any explanation to explain the "why", at least for now. Other people may disagree, but honestly this seems too hard to strike the right balance between conciseness and usefulness of this kind of comment, even for a very experienced scikit-learn contributor ...

Edit: I have edited the PR description to clarify a couple of things, in particular this is not really fixing #30130 which is more about conda (with conda-forge channel) vs pip and is a can of worms IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants