Skip to content

DOC Inspection Examples links in User Guide #30752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

preyasshah9
Copy link
Contributor

What does this implement/fix? Explain your changes.
Add links to the examples from user guide. Towards #30621.

Copy link

github-actions bot commented Feb 3, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5e96d50. Link to the linter CI: here

@preyasshah9 preyasshah9 force-pushed the doc_inspection branch 4 times, most recently from b4555c9 to afd4ad8 Compare February 4, 2025 02:42
@preyasshah9 preyasshah9 marked this pull request as ready for review February 4, 2025 03:11
Copy link
Contributor

@StefanieSenger StefanieSenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @preyasshah9!

This looks very good to me. I was just wondering about the subheading order of the "ICE vs. PDP" part.

And there is a CI failure that is unrelated to this PR. Let me check.

@StefanieSenger StefanieSenger self-requested a review February 4, 2025 09:43
@StefanieSenger
Copy link
Contributor

@preyasshah9, would you mind to push an empty commit to re-trigger the CI? The tests then will hopefully pass.

@preyasshah9
Copy link
Contributor Author

@preyasshah9, would you mind to push an empty commit to re-trigger the CI? The tests then will hopefully pass.

I pushed another commit to remove that subhead ordering update 👍

Copy link
Contributor

@StefanieSenger StefanieSenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @preyasshah9. For me everything looks fine now. I have checked the rendered docs and everything is working. Also the links are in the right places.

Can we merge this, @adrinjalali?

@@ -17,6 +17,7 @@ to diagnose issues with model performance.

.. rubric:: Examples

* :ref:`sphx_glr_auto_examples_inspection_plot_causal_interpretation.py`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this example doesn't have a single inspection import, so removing it from here. That example certainly deserves to be linked from more places, but I'm not sure where.

Comment on lines +1913 to +1914
.. versionchanged:: 1.6
The default value changed from `None` to `"from_dtype"`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it consistent with the other class

@adrinjalali adrinjalali enabled auto-merge (squash) February 13, 2025 12:55
@adrinjalali adrinjalali merged commit fabae96 into scikit-learn:main Feb 13, 2025
32 of 33 checks passed
@lesteve
Copy link
Member

lesteve commented Mar 27, 2025

@preyasshah9 was the addition of bench_num_threads.parquet intended in this PR?

@lesteve
Copy link
Member

lesteve commented Mar 27, 2025

It probably was not intended, I opened #31090 to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants