-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC Inspection Examples links in User Guide #30752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b4555c9
to
afd4ad8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, @preyasshah9!
This looks very good to me. I was just wondering about the subheading order of the "ICE vs. PDP" part.
And there is a CI failure that is unrelated to this PR. Let me check.
@preyasshah9, would you mind to push an empty commit to re-trigger the CI? The tests then will hopefully pass. |
afd4ad8
to
876b9de
Compare
I pushed another commit to remove that subhead ordering update 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @preyasshah9. For me everything looks fine now. I have checked the rendered docs and everything is working. Also the links are in the right places.
Can we merge this, @adrinjalali?
doc/inspection.rst
Outdated
@@ -17,6 +17,7 @@ to diagnose issues with model performance. | |||
|
|||
.. rubric:: Examples | |||
|
|||
* :ref:`sphx_glr_auto_examples_inspection_plot_causal_interpretation.py` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this example doesn't have a single inspection import, so removing it from here. That example certainly deserves to be linked from more places, but I'm not sure where.
.. versionchanged:: 1.6 | ||
The default value changed from `None` to `"from_dtype"`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make it consistent with the other class
@preyasshah9 was the addition of |
It probably was not intended, I opened #31090 to remove it. |
What does this implement/fix? Explain your changes.
Add links to the examples from user guide. Towards #30621.