Skip to content

DOC: Add from_predictions example and other details to visualizations.rst #30825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
May 26, 2025
Merged

DOC: Add from_predictions example and other details to visualizations.rst #30825

merged 27 commits into from
May 26, 2025

Conversation

DeaMariaLeon
Copy link
Contributor

@DeaMariaLeon DeaMariaLeon commented Feb 13, 2025 •
edited
Loading

Reference Issues/PRs

Fixes #30767

What does this implement/fix? Explain your changes.

I tried to address all the points in the issue, and clarify a bit more.

Any other comments?

I moved ln 37, 38: "Be aware that we could get
the predictions from the support vector machine and then use from_predictions
instead of from_estimator." To the bottom, above the new example (written a bit differently).
I can leave it untouched if you prefer of course.

WDYT? @lucyleeow @glemaitre

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 4c6c5f2. Link to the linter CI: here

lucyleeow
lucyleeow reviewed Feb 14, 2025
View reviewed changes
lucyleeow
lucyleeow approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first 2 plots (that you didn't touch) do no show in the rendered doc: https://output.circle-artifacts.com/output/job/5e0cade1-0c1e-4276-9a7c-728c32f8ff27/artifacts/0/doc/visualizations.html but the new plot you add does. Is this just a CI thing where it doesn't run if it hasn't been changed...?

Looks good otherwise, just some nits

@DeaMariaLeon
Copy link
Contributor Author

DeaMariaLeon commented Feb 14, 2025 •
edited
Loading

The first 2 plots (that you didn't touch) do no show in the rendered doc: https://output.circle-artifacts.com/output/job/5e0cade1-0c1e-4276-9a7c-728c32f8ff27/artifacts/0/doc/visualizations.html but the new plot you add does. Is this just a CI thing where it doesn't run if it hasn't been changed...?

I see 3 plots on the created docs. Could you clarify what you mean please? @lucyleeow

@lucyleeow
Copy link
Member

Nevermind I see 3 plots now. I guess it was just my browser? sorry!

@DeaMariaLeon
Copy link
Contributor Author

No need to be sorry.

StefanieSenger
StefanieSenger approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@StefanieSenger StefanieSenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like these changes. Thank you, @DeaMariaLeon! <3

glemaitre
glemaitre reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of thoughts regarding this doc. I think there are more tricky stuff to explain about from_predictions that are really not straightforward :)

lucyleeow
lucyleeow reviewed Mar 12, 2025
View reviewed changes
Copy link
Member

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits and a question. Thank you!

lucyleeow
lucyleeow reviewed Mar 12, 2025
View reviewed changes
@glemaitre glemaitre self-requested a review March 19, 2025 08:26
glemaitre
glemaitre reviewed May 9, 2025
View reviewed changes
glemaitre
glemaitre reviewed May 9, 2025
View reviewed changes
glemaitre
glemaitre reviewed May 9, 2025
View reviewed changes
@glemaitre
Copy link
Member

Just a couple of comment more. @DeaMariaLeon could you resolve the comment from @lucyleeow that were addressed.

lucyleeow
lucyleeow reviewed May 12, 2025
View reviewed changes
Copy link
Member

@lucyleeow lucyleeow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits.

lucyleeow
lucyleeow reviewed May 15, 2025
View reviewed changes
Copy link
Member

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment otherwise LGTM.

One note, are all lines under 88 characters?

@DeaMariaLeon
Copy link
Contributor Author

One note, are all lines under 88 characters?

Yes.. (after your feedback). Thanks.

@DeaMariaLeon
Copy link
Contributor Author

Friendly ping @lucyleeow

lucyleeow
lucyleeow reviewed May 21, 2025
View reviewed changes
@DeaMariaLeon
Copy link
Contributor Author

Changes done @lucyleeow

lucyleeow
lucyleeow approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though not sure if worth a second review from @glemaitre after the changes.

glemaitre
glemaitre approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still looks good on my side.

Merging. Thanks @DeaMariaLeon and @lucyleeow

@glemaitre glemaitre merged commit 4b3a69a into scikit-learn:main May 26, 2025
36 checks passed
@DeaMariaLeon DeaMariaLeon deleted the from_pred branch May 26, 2025 08:02
jeremiedbb pushed a commit to jeremiedbb/scikit-learn that referenced this pull request May 30, 2025
@DeaMariaLeon @jeremiedbb
DOC: Add from_predictions example and other details to `visualizati…
d3e0180 
…ons.rst` (scikit-learn#30825)
elhambbi pushed a commit to elhambbi/scikit-learn that referenced this pull request Jun 1, 2025
@DeaMariaLeon @elhambbi
DOC: Add from_predictions example and other details to `visualizati…
4a5abba 
…ons.rst` (scikit-learn#30825)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

@lucyleeow lucyleeow lucyleeow approved these changes

@StefanieSenger StefanieSenger StefanieSenger approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOC Add from_predictions example to visualizations.rst
4 participants
@DeaMariaLeon @lucyleeow @glemaitre @StefanieSenger