Skip to content

CI Work around the lack of Windows free-threaded wheel for pandas #31159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Apr 7, 2025

Fix #31128. pandas does not have a Windows free-threaded wheel and for some reason has not uploaded one development wheel in scientific-python-nightly-wheel see pandas-dev/pandas#61242.

For the time being, I think it is acceptable for Windows free-threaded to run tests without pandas installed. Once pandas has a release with Windows free-threaded wheel we will add pandas back.

I also took the opportunity to use released scipy scipy 1.15.2 has free-threaded wheels for all OSes according to the 1.15.2 PyPI info. I can split it to a different PR if you insist.

Copy link

github-actions bot commented Apr 7, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 8ac5cd7. Link to the linter CI: here

@lesteve lesteve changed the title CI Use released versions for free threaded CI Use released versions for free threaded wheels Apr 7, 2025
@lesteve lesteve changed the title CI Use released versions for free threaded wheels CI Work around the lack of Windows free-threaded wheel for pandas Apr 7, 2025
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jeremiedbb jeremiedbb merged commit 16f7d5a into scikit-learn:main Apr 9, 2025
63 checks passed
@lesteve lesteve deleted the use-released-versions-for-free-threaded branch April 9, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ CI failed on Wheel builder (last failure: Apr 09, 2025) ⚠️
3 participants