DOC Simplify Windows build instructions #31202
Conversation
| command depends on the architecture of the Python interpreter. You can check | ||
| the architecture by running the following in ``cmd`` or ``powershell`` | ||
| console: | ||
| Build scikit-learn by running the following command in a Miniforge or Command prompt: |
There was a problem hiding this comment.
Isn't it better to leave this line as it is?. Just saying to run the command in the prompt without saying Miniforge.
Because in any other place, it was not mentioned the term "Miniforge" before.
Just to avoid confusion, like (what is Miniforge if I am using Anaconda prompt/ C:/Linux prompt ?)
Comment based solely on my opinion.
| Build scikit-learn by running the following command in a Miniforge or Command prompt: | |
| Build scikit-learn by running the following command prompt: |
There was a problem hiding this comment.
I pushed a change mentioning the conda env or virtualenv rather than which console to use.
FYI, in my Windows VM setup I mostly use conda. I have installed Miniforge through https://conda-forge.org/download/ which is a miniconda install using conda-forge as the default channel. This is one of the setup I would recommend if you are using conda.
There was a problem hiding this comment.
Thanks for clarifying @lesteve !
I knew that Miniforge was associated with conda in some way, but honestly, I have never used it.
I will remember this advice for the future.
|
Also bumped into astropy/astropy#17760 (comment) (for a completely unrelated reason) which confirms that Meson will find the MSVC compiler automatically:
|
There was a problem hiding this comment.
LGTM, looks outdated indeed. Thanks @vitorpohlenz for the confirmation.
Follow up of #31173.
vcvarsall.batcommand which has been removed\for line continuation doesn't work inside a cmd.exe console