MNT Add missing cython-lint install in lint workflow #31208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced by this commit in scikit-learn#31015: 620b0de MNT black → ruff format
|
I enabled auto-merge, this will be merged automatically when CI is green. |
|
@lesteve The thing is that CI cannot be green because the linter CI job is partly driven by |
|
Auto-merge will still work, it relies "required" check to be green and right now the GHA linting is not a "required" check. |
|
The linting workflow seems fine now in PRs for example #31202 (I just merged |
lucyleeow
pushed a commit
to EmilyXinyi/scikit-learn
that referenced
this pull request
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See #31015.
What does this implement/fix? Explain your changes.
Fix bug introduced by this commit in #31015:
620b0de MNT black → ruff format
Any other comments?
See for example;
https://github.com/scikit-learn/scikit-learn/actions/runs/14468417323/job/40576084429?pr=31207
The linter issue cannot be entirely fixed within this PR, because the CI job is partly driven by
main. See #31015 (review) and #31015 (review).