Skip to content

Enhance ROC Curve Display Tests for Improved Clarity and Maintainability #31254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

NEREUScode
Copy link
Contributor

Commit Description:

Replaced the data_binary fixture that filtered classes from a multiclass dataset with a new fixture generating a synthetic binary classification dataset using make_classification. This ensures consistent data characteristics, introduces label noise, and better simulates real-world classification challenges.


PR Description:

Summary of Changes:

This PR refactors the data_binary fixture in the test_roc_curve_display.py file. The previous fixture filtered a multiclass dataset (Iris) to create a binary classification task. However, this approach resulted in AUC values consistently reaching 1.0, which does not reflect real-world challenges.

The new fixture utilizes make_classification from sklearn.datasets to generate a synthetic binary classification dataset with the following characteristics:

  • 200 samples and 20 features.
  • 5 informative features and 2 redundant features.
  • 10% label noise (flip_y=0.1) to simulate real-world imperfections in the data.
  • Class separation (class_sep=0.8) set to avoid perfect separation.

These changes provide a more complex and representative dataset for testing the roc_curve_display function and other related metrics, thereby improving the robustness of tests.

Reference Issues/PRs:


For Reviewers:

  • This change ensures that the dataset used for testing is more reflective of real-world data, particularly in classification tasks that may involve noise and less clear separation between classes.

Replaced the `data_binary` fixture that filtered classes from a multiclass dataset 
with a new fixture generating a synthetic binary classification dataset using 
`make_classification`. This ensures consistent data characteristics, introduces 
label noise, and better simulates real-world classification challenges.
Copy link

github-actions bot commented Apr 25, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: e8b1e45. Link to the linter CI: here

Copy link
Member

@lucyleeow lucyleeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

There is a lint problem, see: #31254 (comment)

Just 2 items, otherwise looks good.

@@ -26,8 +26,16 @@ def data():

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the data fixture above can be removed as it is now no longer used (please double check).

Comment on lines +31 to +32
n_features=20,
n_informative=5,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need that many features (and so many uninformative ones), but I will leave to another maintainer to determine.

@NEREUScode NEREUScode closed this Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use more complex data in test_roc_curve_display.py
2 participants