-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Enhance ROC Curve Display Tests for Improved Clarity and Maintainability #31254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replaced the `data_binary` fixture that filtered classes from a multiclass dataset with a new fixture generating a synthetic binary classification dataset using `make_classification`. This ensures consistent data characteristics, introduces label noise, and better simulates real-world classification challenges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
There is a lint problem, see: #31254 (comment)
Just 2 items, otherwise looks good.
@@ -26,8 +26,16 @@ def data(): | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the data
fixture above can be removed as it is now no longer used (please double check).
n_features=20, | ||
n_informative=5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we need that many features (and so many uninformative ones), but I will leave to another maintainer to determine.
Commit Description:
Replaced the
data_binary
fixture that filtered classes from a multiclass dataset with a new fixture generating a synthetic binary classification dataset usingmake_classification
. This ensures consistent data characteristics, introduces label noise, and better simulates real-world classification challenges.PR Description:
Summary of Changes:
This PR refactors the
data_binary
fixture in thetest_roc_curve_display.py
file. The previous fixture filtered a multiclass dataset (Iris) to create a binary classification task. However, this approach resulted in AUC values consistently reaching 1.0, which does not reflect real-world challenges.The new fixture utilizes
make_classification
fromsklearn.datasets
to generate a synthetic binary classification dataset with the following characteristics:flip_y=0.1
) to simulate real-world imperfections in the data.class_sep=0.8
) set to avoid perfect separation.These changes provide a more complex and representative dataset for testing the
roc_curve_display
function and other related metrics, thereby improving the robustness of tests.Reference Issues/PRs:
test_roc_curve_display.py
#31243from_cv_results
inRocCurveDisplay
(singleRocCurveDisplay
) #30399 (comment)For Reviewers: