DOC: Update macOS Homebrew libomp instructions for Apple Silicon #31369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyleeow
reviewed
May 15, 2025
There was a problem hiding this comment.
Thanks @TeckHack76 , just a quick comment, could you make lines under 88 characters?
|
There was already a PR opened on this very recently #31361. I am going to close this PR, thanks for your understanding @TeckHack76. |
|
Thanks for the feedback and for reviewing the PR! I understand it was a duplicate - no problem at all. I appreciate the guidance and will keep the 88-character line rule in mind for future contributions. I'm looking forward to contributing more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation in the "macOS compilers from Homebrew" section to clarify
The installation paths of
libompfor different Mac architectures.libompin Homebrew./usr/local/opt/libomp) and Apple Silicon Macs (using/opt/homebrew/opt/libomp).libompprefix path usingbrew --prefix libomp.These changes help Apple Silicon users avoid confusion and build errors when installing scikit-learn from source.
Closes #31359