-
-
Notifications
You must be signed in to change notification settings - Fork 26.1k
FIX FunctionTransformer.get_feature_names_out
when output is set to dataframe
#31573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
FIX FunctionTransformer.get_feature_names_out
when output is set to dataframe
#31573
Conversation
get_feature_names_out
when fitted with a dataframeget_feature_names_out
when fitted with a dataframe
get_feature_names_out
when fitted with a dataframeget_feature_names_out
when output is set to dataframe
d48690e
to
158d7ed
Compare
get_feature_names_out
when output is set to dataframeFunctionTransformer.get_feature_names_out
when output is set to dataframe
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Hello @adrinjalali, implemented all the reviews. If there is more feedback or any other actions needed for merge let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks. Maybe @jeremiedbb could have a look?
I'm not sure this is the right "fix" for #28780, and wouldn't mind keeping the current behavior of requiring |
Reference Issues/PRs
Fixes #28780
What does this implement/fix? Explain your changes.
When
FunctionTransformer
:feature_names_out
set to Noneset_output
called with "pandas" or "polars"Then
get_feature_names_out()
should return the output dataframe's columns. However, it raises an AttributeError instead.A specific example, copied from the issue's discussions:
Any other comments?
To get the output column names, I saw three options:
func
on the fitted data(1) means calling the function twice during a fit_transform, whereas (2) means making transform a stateful operation. (3) means that the specific example above, when called without an argument, would still fail.
I went with (1): during
fit
, callfunc
with a smaller slice of the input in order to get output dataframe column names. If that's not desirable let me know and I can change the approach.The fix works both for pandas and polars dataframes.