-
-
Notifications
You must be signed in to change notification settings - Fork 26k
FIX FunctionTransformer.get_feature_names_out
when output is set to dataframe
#31573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
osyuksel
wants to merge
17
commits into
scikit-learn:main
Choose a base branch
from
osyuksel:fix-functransformer-df-output
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
FIX FunctionTransformer.get_feature_names_out
when output is set to dataframe
#31573
osyuksel
wants to merge
17
commits into
scikit-learn:main
from
osyuksel:fix-functransformer-df-output
+61
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_feature_names_out
when fitted with a dataframeget_feature_names_out
when fitted with a dataframe
get_feature_names_out
when fitted with a dataframeget_feature_names_out
when output is set to dataframe
d48690e
to
158d7ed
Compare
get_feature_names_out
when output is set to dataframeFunctionTransformer.get_feature_names_out
when output is set to dataframe
adrinjalali
reviewed
Jun 19, 2025
adrinjalali
reviewed
Jul 2, 2025
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #28780
What does this implement/fix? Explain your changes.
When
FunctionTransformer
:feature_names_out
set to Noneset_output
called with "pandas" or "polars"Then
get_feature_names_out()
should return the output dataframe's columns. However, it raises an AttributeError instead.A specific example, copied from the issue's discussions:
Any other comments?
To get the output column names, I saw three options:
func
on the fitted data(1) means calling the function twice during a fit_transform, whereas (2) means making transform a stateful operation. (3) means that the specific example above, when called without an argument, would still fail.
I went with (1): during
fit
, callfunc
with a smaller slice of the input in order to get output dataframe column names. If that's not desirable let me know and I can change the approach.The fix works both for pandas and polars dataframes.