[MRG] Fix flake8_diff.sh git repo unshallowing #7575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which fixes the issue seen in scikit-learn#7027. Enhancements: * the script works on PRs targetting a fork rather than the reference repo * improved logic about when to unshallow the repo * fetching the upstream master branch into a reference rather than a branch (less intrusive for scripts than may run afterwards e.g. the ones in the after_success step) * Better logging messages
|
OK the Travis build looks good so I'll merge this one. |
This was referenced Oct 4, 2016
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
which fixes the issue seen in scikit-learn#7027. Enhancements: * the script works on PRs targetting a fork rather than the reference repo * improved logic about when to unshallow the repo * fetching the upstream master branch into a reference rather than a branch (less intrusive for scripts than may run afterwards e.g. the ones in the after_success step) * Better logging messages
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
which fixes the issue seen in scikit-learn#7027. Enhancements: * the script works on PRs targetting a fork rather than the reference repo * improved logic about when to unshallow the repo * fetching the upstream master branch into a reference rather than a branch (less intrusive for scripts than may run afterwards e.g. the ones in the after_success step) * Better logging messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which fixes the issue seen in #7027 (comment).
Enhancements:
repo
branch (less intrusive for scripts than may run afterwards e.g. the
ones in the after_success step)
I'll just wait the CI on this one and probably merge if everything is green.