[MRG] DOC cleaning up what's new for 0.19 #9252

jnothman · 2017-06-30T02:39:26Z

subsections, reclassifications, etc

Marked WIP only because of optimistic inclusion of multiple metrics, which is not yet merged.

ogrisel · 2017-07-04T14:14:16Z

doc/whats_new.rst

-     :issue:`9105` by `Hanmin Qin <https://github.com/qinhanmin2014>`_.
+   - :class:`neighbors.LSHForest` has been deprecated and will be
+     removed in 0.21 due to poor performance.
+     :issue:`8996` by `Andreas Müller`_.


This item does not seem to belong to "Linear, kernelized and related models".

issue by me, but not the fix, so probably should be a different name?

ogrisel · 2017-07-04T14:15:32Z

doc/whats_new.rst

-     would fail with a unmeaningful error by default.
-     :issue:`6573` by :user:`Quazi Marufur Rahman <qmaruf>` and
-     `Manoj Kumar`_.
+Linear, kernelized and related models


Maybe we should have one section name "Neighborhood models" and another "Semi-supervised learning models" instead?

jnothman · 2017-07-04T21:39:34Z

I am fine to make more or different headings if it is helpful.

…

On 5 Jul 2017 12:15 am, "Olivier Grisel" ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In doc/whats_new.rst <#9252 (comment)> : > - - Fixed a bug in :class:`gaussian_process.GaussianProcessRegressor` - when the standard deviation and covariance predicted without fit - would fail with a unmeaningful error by default. - :issue:`6573` by :user:`Quazi Marufur Rahman <qmaruf>` and - `Manoj Kumar`_. +Linear, kernelized and related models Maybe we should have one section name "Neighborhood models" and another "Semi-supervised learning models" instead? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9252 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEz6xLGkDt9e2iSoj3KyrSfjZRW0y0Jks5sKkkGgaJpZM4OKFjl> .

jnothman · 2017-07-04T21:40:54Z

of course could just group by subpackage

…

On 5 Jul 2017 7:39 am, "Joel Nothman" ***@***.***> wrote: I am fine to make more or different headings if it is helpful. On 5 Jul 2017 12:15 am, "Olivier Grisel" ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In doc/whats_new.rst > <#9252 (comment)> > : > > > > - - Fixed a bug in :class:`gaussian_process.GaussianProcessRegressor` > - when the standard deviation and covariance predicted without fit > - would fail with a unmeaningful error by default. > - :issue:`6573` by :user:`Quazi Marufur Rahman <qmaruf>` and > - `Manoj Kumar`_. > +Linear, kernelized and related models > > Maybe we should have one section name "Neighborhood models" and another > "Semi-supervised learning models" instead? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#9252 (review)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAEz6xLGkDt9e2iSoj3KyrSfjZRW0y0Jks5sKkkGgaJpZM4OKFjl> > . >

jnothman · 2017-07-04T23:35:30Z

Unless we want to completely group by subpackage, which might make sense but seems unnecessarily fine-grained for this purpose, I've just added "other predictors".

I had included neighbors and semi_supervised under "linear, kernelised et al" because of how they use affinities. But so does clustering. And so do kernels. And most of our decompositions are linear. So we're splitting hairs in any case. Would you rather I group by subpackage?

amueller · 2017-07-05T15:48:55Z

can you merge it with the 0.18.2 whatsnew?

lesteve · 2017-07-06T09:22:35Z

doc/whats_new.rst

-   - The ``n_topics`` parameter of :class:`decomposition.LatentDirichletAllocation`
-     has been renamed to ``n_components`` and will be removed in version 0.21.
-     :issue:`8922` by :user:`Attractadore`
+Metrics


This section is empty, should it be removed?

lesteve · 2017-07-06T09:45:47Z

I push a couple of changes but apart from the empty "Metrics" section, LGTM.

amueller

Are you sure we should release? That really seems like to little to warrant a new version ;)

amueller · 2017-07-06T19:35:21Z

doc/modules/classes.rst

@@ -1391,6 +1389,18 @@ Recently deprecated
 ===================


+To be removed in 0.21


nitpickiest nitpick: shouldn't that go below removed in 0.20? though no strong opinion.

Mostly the point of listing them is so that autodoc generates. Order shmorder.

amueller · 2017-07-06T19:35:59Z

doc/whats_new.rst

+We are excited to release a number of great new features including
+:class:`neighbors.LocalOutlierFactor` for anomaly detection,
+:class:`preprocessing.QuantileTransformer` for robust feature
+transformation, and :class:`multioutput.ClassifierChain` to simply


Maybe say that ClassifierChain is a meta-estimator?

amueller · 2017-07-06T19:36:15Z

doc/whats_new.rst

+account for dependencies between classes in multilabel problems. We
+have some new algorithms in existing estimators, such as
+multiplicative update in :class:`decomposition.NMF` and multinomial
+:class:`linear_model.LogisticRegression` with L1 loss.


via the saga solver?

amueller · 2017-07-06T19:36:45Z

doc/whats_new.rst

+you can predict faster: if you're sure you know what you're doing, you can turn
+off validating that the input is finite using :func:`config_context`.
+
+Cross validation is now able to return the results from multiple metric


that's not merged yet, right?

no, it's not. Nor are the TSNE fixes. Being optimisitc, and getting the writing out of the way.

amueller · 2017-07-06T19:37:51Z

doc/whats_new.rst

+:class:`manifold.TSNE` implementation have been fixed, particularly in the
+default Barnes-Hut approximation.  :class:`semi_supervised.LabelSpreading` and
+:class:`semi_supervised.LabelPropagation` have had substantial fixes.
+Propagation was previously broken. Spreading should now correctly respect its


LabelPropagation?

amueller · 2017-07-06T19:40:32Z

doc/whats_new.rst

+   - Fixed a bug in :class:`linear_model.RandomizedLasso`,
+     :class:`linear_model.Lars`, :class:`linear_model.LassoLars`,
+     :class:`linear_model.LarsCV` and :class:`linear_model.LassoLarsCV`,
+     where the parameter ``precompute`` were not used consistently across


amueller · 2017-07-06T19:40:48Z

doc/whats_new.rst

-     where a float being compared to ``0.0`` using ``==`` caused a divide by zero
-     error. issue:`7970` by :user:`He Chen <chenhe95>`.
+   - Fix a bug where :func:`linear_model.LassoLars.fit` sometimes
+     left `coef_` as a list, rather than an ndarray.


double backticks?

amueller · 2017-07-06T19:40:57Z

doc/whats_new.rst

-     array X and initial centroids, where X's means were unnecessarily being
-     subtracted from the centroids. :issue:`7872` by :user:`Josh Karnofsky <jkarno>`.
+   - Fix :func:`linear_model.BayesianRidge.fit` to return
+     ridge parameter `alpha_` and `lambda_` consistent with calculated


double backtricks everywhere?

amueller · 2017-07-06T19:41:15Z

doc/whats_new.rst

   - Fix output shape and bugs with n_jobs > 1 in
     :class:`decomposition.SparseCoder` transform and
     :func:`decomposition.sparse_encode`
     for one-dimensional data and one component.
     This also impacts the output shape of :class:`decomposition.DictionaryLearning`.
     :issue:`8086` by `Andreas Müller`_.

+   - Fixed the implementation of `explained_variance_`


double backticks?

amueller · 2017-07-06T19:42:39Z

doc/whats_new.rst

-     :issue:`9105` by `Hanmin Qin <https://github.com/qinhanmin2014>`_.
+   - :class:`neighbors.LSHForest` has been deprecated and will be
+     removed in 0.21 due to poor performance.
+     :issue:`8996` by `Andreas Müller`_.


issue by me, but not the fix, so probably should be a different name?

jnothman · 2017-07-07T04:59:53Z

Are you sure we should release? That really seems like to little to warrant a new version ;)

Maybe we've missed something? Make sure you go back and check the logs before giving this LGTM. :P

… whatsnew-0.19

amueller · 2017-07-12T21:07:21Z

why are there conflicts in the tsne test?

jnothman · 2017-07-12T22:19:03Z

Weird. Must have been a merge error on my part. I'll fix it up shortly

jnothman · 2017-07-12T22:52:41Z

Marking MRG

And other minor things. This took lots of effort which I would have not committed where I not home sick...

jnothman · 2017-07-13T05:54:46Z

Okay. Let's do a release, then :)

* DOC cleaning up what's new for 0.19 * More cleaning up * More cleaning up * Deprecations * Clean up merge * Update * TODOs to prose and minor changes * Changed models and minor fixes * sort * Merge in 0.18.2 docs * Missing entry from 0.18 logs * Optimistically add some features to highlights * Forgotten user directive * Fix alignment * Cleaning up for Andy's comments * Mention beta_loss=0 speedup * Update * Clean up new what's new entries * DOC Add changes missed from what's new And other minor things. This took lots of effort which I would have not committed where I not home sick...

Release 0.19b2 * tag '0.19b2': (808 commits) Preparing 0.19b2 [MRG+1] FIX out of bounds array access in SAGA (scikit-learn#9376) FIX make test_importances pass on 32 bit linux Release 0.19b1 DOC remove 'in dev' header in whats_new.rst DOC typos in whats_news.rst [ci skip] [MRG] DOC cleaning up what's new for 0.19 (scikit-learn#9252) FIX t-SNE memory usage and many other optimizer issues (scikit-learn#9032) FIX broken link in gallery and bad title rendering [MRG] DOC Replace \acute by prime (scikit-learn#9332) Fix typos (scikit-learn#9320) [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (scikit-learn#9206) DOC Residual sum vs. regression sum (scikit-learn#9314) [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (scikit-learn#9317) More informative error message for classification metrics given regression output (scikit-learn#9275) [MRG] COSMIT Remove unused parameters in private functions (scikit-learn#9310) [MRG+1] Ridgecv normalize (scikit-learn#9302) [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (scikit-learn#7388) Add data_home parameter to fetch_kddcup99 (scikit-learn#9289) FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284) ...

* releases: (808 commits) Preparing 0.19b2 [MRG+1] FIX out of bounds array access in SAGA (scikit-learn#9376) FIX make test_importances pass on 32 bit linux Release 0.19b1 DOC remove 'in dev' header in whats_new.rst DOC typos in whats_news.rst [ci skip] [MRG] DOC cleaning up what's new for 0.19 (scikit-learn#9252) FIX t-SNE memory usage and many other optimizer issues (scikit-learn#9032) FIX broken link in gallery and bad title rendering [MRG] DOC Replace \acute by prime (scikit-learn#9332) Fix typos (scikit-learn#9320) [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (scikit-learn#9206) DOC Residual sum vs. regression sum (scikit-learn#9314) [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (scikit-learn#9317) More informative error message for classification metrics given regression output (scikit-learn#9275) [MRG] COSMIT Remove unused parameters in private functions (scikit-learn#9310) [MRG+1] Ridgecv normalize (scikit-learn#9302) [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (scikit-learn#7388) Add data_home parameter to fetch_kddcup99 (scikit-learn#9289) FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284) ...

* dfsg: (808 commits) Preparing 0.19b2 [MRG+1] FIX out of bounds array access in SAGA (scikit-learn#9376) FIX make test_importances pass on 32 bit linux Release 0.19b1 DOC remove 'in dev' header in whats_new.rst DOC typos in whats_news.rst [ci skip] [MRG] DOC cleaning up what's new for 0.19 (scikit-learn#9252) FIX t-SNE memory usage and many other optimizer issues (scikit-learn#9032) FIX broken link in gallery and bad title rendering [MRG] DOC Replace \acute by prime (scikit-learn#9332) Fix typos (scikit-learn#9320) [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (scikit-learn#9206) DOC Residual sum vs. regression sum (scikit-learn#9314) [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (scikit-learn#9317) More informative error message for classification metrics given regression output (scikit-learn#9275) [MRG] COSMIT Remove unused parameters in private functions (scikit-learn#9310) [MRG+1] Ridgecv normalize (scikit-learn#9302) [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (scikit-learn#7388) Add data_home parameter to fetch_kddcup99 (scikit-learn#9289) FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284) ...

* DOC cleaning up what's new for 0.19 * More cleaning up * More cleaning up * Deprecations * Clean up merge * Update * TODOs to prose and minor changes * Changed models and minor fixes * sort * Merge in 0.18.2 docs * Missing entry from 0.18 logs * Optimistically add some features to highlights * Forgotten user directive * Fix alignment * Cleaning up for Andy's comments * Mention beta_loss=0 speedup * Update * Clean up new what's new entries * DOC Add changes missed from what's new And other minor things. This took lots of effort which I would have not committed where I not home sick...

jnothman added 3 commits June 30, 2017 12:38

DOC cleaning up what's new for 0.19

271f339

More cleaning up

b504e9e

More cleaning up

24c742b

jnothman added this to the 0.19 milestone Jun 30, 2017

jnothman added Blocker Documentation labels Jun 30, 2017

jnothman added 5 commits July 1, 2017 20:37

Deprecations

187ee22

Merge branch 'master' into whatsnew-0.19

6e9066a

Clean up merge

37df822

Merge branch 'master' into whatsnew-0.19

cbaeb25

Update

ce53580

ogrisel reviewed Jul 4, 2017

View reviewed changes

jnothman added 4 commits July 5, 2017 11:12

TODOs to prose and minor changes

89d5ea9

Merge branch 'master' into whatsnew-0.19

4b65c64

Changed models and minor fixes

736e93f

sort

8d1fff8

jnothman added 3 commits July 6, 2017 07:43

Merge in 0.18.2 docs

acc4e31

Missing entry from 0.18 logs

8c27599

Optimistically add some features to highlights

0b8b79f

lesteve reviewed Jul 6, 2017

View reviewed changes

lesteve added 2 commits July 6, 2017 11:39

Forgotten user directive

eb05651

Fix alignment

5cc2b28

amueller reviewed Jul 6, 2017

View reviewed changes

Cleaning up for Andy's comments

9643fc4

jnothman added 2 commits July 7, 2017 14:54

Merge branch 'master' into whatsnew-0.19

6a9b67c

Mention beta_loss=0 speedup

08fc42c

jnothman added 3 commits July 7, 2017 15:00

Merge branch 'whatsnew-0.19' of github.com:jnothman/scikit-learn into…

1b9c439

… whatsnew-0.19

Merge branch 'master' into whatsnew-0.19

6c39897

Update

6aa9fd0

jnothman added 2 commits July 13, 2017 08:48

Merge branch 'master' into whatsnew-0.19

e4e44a1

Clean up new what's new entries

09878d4

jnothman changed the title ~~[WIP] DOC cleaning up what's new for 0.19~~ [MRG] DOC cleaning up what's new for 0.19 Jul 12, 2017

DOC Add changes missed from what's new

0312156

And other minor things. This took lots of effort which I would have not committed where I not home sick...

jnothman merged commit ba72248 into scikit-learn:master Jul 13, 2017

jnothman deleted the whatsnew-0.19 branch July 13, 2017 05:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MRG] DOC cleaning up what's new for 0.19 #9252

[MRG] DOC cleaning up what's new for 0.19 #9252

jnothman commented Jun 30, 2017 •

edited

Loading

ogrisel Jul 4, 2017

amueller Jul 6, 2017

ogrisel Jul 4, 2017

jnothman commented Jul 4, 2017 via email

jnothman commented Jul 4, 2017 via email

jnothman commented Jul 4, 2017

amueller commented Jul 5, 2017

lesteve Jul 6, 2017

lesteve commented Jul 6, 2017

amueller left a comment

amueller Jul 6, 2017

jnothman Jul 7, 2017

amueller Jul 6, 2017

amueller Jul 6, 2017

amueller Jul 6, 2017

jnothman Jul 7, 2017

amueller Jul 6, 2017

amueller Jul 6, 2017

amueller Jul 6, 2017

amueller Jul 6, 2017

amueller Jul 6, 2017

amueller Jul 6, 2017

jnothman commented Jul 7, 2017

amueller commented Jul 12, 2017

jnothman commented Jul 12, 2017

jnothman commented Jul 12, 2017

jnothman commented Jul 13, 2017

		@@ -1391,6 +1389,18 @@ Recently deprecated
		===================


		To be removed in 0.21

[MRG] DOC cleaning up what's new for 0.19 #9252

[MRG] DOC cleaning up what's new for 0.19 #9252

Conversation

jnothman commented Jun 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jnothman commented Jul 4, 2017 via email

jnothman commented Jul 4, 2017 via email

jnothman commented Jul 4, 2017

amueller commented Jul 5, 2017

Choose a reason for hiding this comment

lesteve commented Jul 6, 2017

amueller left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jnothman commented Jul 7, 2017

amueller commented Jul 12, 2017

jnothman commented Jul 12, 2017

jnothman commented Jul 12, 2017

jnothman commented Jul 13, 2017

jnothman commented Jun 30, 2017 •

edited

Loading