Skip to content

[MRG] COSMIT Remove unused parameters in private functions #9310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2017
Merged

[MRG] COSMIT Remove unused parameters in private functions #9310

merged 3 commits into from
Jul 10, 2017

Conversation

jnothman
Copy link
Member

@glemaitre
Copy link
Member

LGTM +1

@jnothman jnothman changed the title [MRG] COSMIT Remove unused parameter [MRG] COSMIT Remove unused parameters in private functions Jul 10, 2017
@TomDLT
Copy link
Member

TomDLT commented Jul 10, 2017

LGTM

@TomDLT TomDLT merged commit 0cdd91d into scikit-learn:master Jul 10, 2017
massich pushed a commit to massich/scikit-learn that referenced this pull request Jul 13, 2017
@jnothman
[MRG] COSMIT Remove unused parameters in private functions (scikit-le…
17173d2 
…arn#9310)

* Remove unused parameter

* COSMIT another unused parameter

* COSMIT another unused parameter
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017
@yarikoptic
Merge tag '0.19b2' into releases
ec9e5de 
Release 0.19b2

* tag '0.19b2': (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (scikit-learn#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (scikit-learn#9252)
  FIX t-SNE memory usage and many other optimizer issues (scikit-learn#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (scikit-learn#9332)
  Fix typos (scikit-learn#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (scikit-learn#9206)
  DOC Residual sum vs. regression sum (scikit-learn#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (scikit-learn#9317)
  More informative error message for classification metrics given regression output (scikit-learn#9275)
  [MRG] COSMIT Remove unused parameters in private functions (scikit-learn#9310)
  [MRG+1] Ridgecv normalize (scikit-learn#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (scikit-learn#7388)
  Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284)
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017
@yarikoptic
Merge branch 'releases' into dfsg (reremoved joblib and jquery)
4615112 
* releases: (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (scikit-learn#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (scikit-learn#9252)
  FIX t-SNE memory usage and many other optimizer issues (scikit-learn#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (scikit-learn#9332)
  Fix typos (scikit-learn#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (scikit-learn#9206)
  DOC Residual sum vs. regression sum (scikit-learn#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (scikit-learn#9317)
  More informative error message for classification metrics given regression output (scikit-learn#9275)
  [MRG] COSMIT Remove unused parameters in private functions (scikit-learn#9310)
  [MRG+1] Ridgecv normalize (scikit-learn#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (scikit-learn#7388)
  Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284)
  ...
yarikoptic added a commit to yarikoptic/scikit-learn that referenced this pull request Jul 27, 2017
@yarikoptic
Merge branch 'dfsg' into debian
236bb58 
* dfsg: (808 commits)
  Preparing 0.19b2
  [MRG+1] FIX out of bounds array access in SAGA (scikit-learn#9376)
  FIX make test_importances pass on 32 bit linux
  Release 0.19b1
  DOC remove 'in dev' header in whats_new.rst
  DOC typos in whats_news.rst [ci skip]
  [MRG] DOC cleaning up what's new for 0.19 (scikit-learn#9252)
  FIX t-SNE memory usage and many other optimizer issues (scikit-learn#9032)
  FIX broken link in gallery and bad title rendering
  [MRG] DOC Replace \acute by prime (scikit-learn#9332)
  Fix typos (scikit-learn#9320)
  [MRG + 1 (rv) + 1 (alex) + 1] Add a check to test the docstring params and their order (scikit-learn#9206)
  DOC Residual sum vs. regression sum (scikit-learn#9314)
  [MRG] [HOTFIX] Fix capitalization in test and hence fix failing travis at master (scikit-learn#9317)
  More informative error message for classification metrics given regression output (scikit-learn#9275)
  [MRG] COSMIT Remove unused parameters in private functions (scikit-learn#9310)
  [MRG+1] Ridgecv normalize (scikit-learn#9302)
  [MRG + 2] ENH Allow `cross_val_score`, `GridSearchCV` et al. to evaluate on multiple metrics (scikit-learn#7388)
  Add data_home parameter to fetch_kddcup99 (scikit-learn#9289)
  FIX makedirs(..., exists_ok) not available in Python 2 (scikit-learn#9284)
  ...
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@jnothman @dmohns
[MRG] COSMIT Remove unused parameters in private functions (scikit-le…
b33e181 
…arn#9310)

* Remove unused parameter

* COSMIT another unused parameter

* COSMIT another unused parameter
dmohns pushed a commit to dmohns/scikit-learn that referenced this pull request Aug 7, 2017
@jnothman @dmohns
[MRG] COSMIT Remove unused parameters in private functions (scikit-le…
616fdc6 
…arn#9310)

* Remove unused parameter

* COSMIT another unused parameter

* COSMIT another unused parameter
NelleV pushed a commit to NelleV/scikit-learn that referenced this pull request Aug 11, 2017
@jnothman @NelleV
[MRG] COSMIT Remove unused parameters in private functions (scikit-le…
2bbdeef 
…arn#9310)

* Remove unused parameter

* COSMIT another unused parameter

* COSMIT another unused parameter
paulha pushed a commit to paulha/scikit-learn that referenced this pull request Aug 19, 2017
@jnothman @paulha
[MRG] COSMIT Remove unused parameters in private functions (scikit-le…
c2fb7fd 
…arn#9310)

* Remove unused parameter

* COSMIT another unused parameter

* COSMIT another unused parameter
AishwaryaRK pushed a commit to AishwaryaRK/scikit-learn that referenced this pull request Aug 29, 2017
@jnothman @AishwaryaRK
[MRG] COSMIT Remove unused parameters in private functions (scikit-le…
c928a62 
…arn#9310)

* Remove unused parameter

* COSMIT another unused parameter

* COSMIT another unused parameter
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
@jnothman @maskani-moh
[MRG] COSMIT Remove unused parameters in private functions (scikit-le…
74339bf 
…arn#9310)

* Remove unused parameter

* COSMIT another unused parameter

* COSMIT another unused parameter
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
@jnothman
[MRG] COSMIT Remove unused parameters in private functions (scikit-le…
4d0a7fb 
…arn#9310)

* Remove unused parameter

* COSMIT another unused parameter

* COSMIT another unused parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jnothman @glemaitre @TomDLT