Skip to content

[MRG] Fix math syntax for ComplementNB documentation. #9644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2017
Merged

[MRG] Fix math syntax for ComplementNB documentation. #9644

merged 2 commits into from
Aug 29, 2017

Conversation

airalcorn2
Copy link
Contributor

@airalcorn2 airalcorn2 commented Aug 29, 2017

Attempts to fix the documentation issues brought up by @jnothman here. I was missing a curly bracket in the second fraction, which I suspect was causing the TeX issues (sorry about that). The alpha notation follows the notation in the paper where \alpha = \sum_{i} \alpha_i, which I now mention in the documentation. I've also slightly rearranged the equations to make it obvious that the alphas are not included in the summations.

@lesteve
Copy link
Member

lesteve commented Aug 29, 2017

@lesteve
Copy link
Member

lesteve commented Aug 29, 2017

@jnothman unfortunately there is no way yet to force building the LaTeX documentation in a PR so we may as well merge this and see whether that fixes the CircleCI build error on master ...

@lesteve
Copy link
Member

lesteve commented Aug 29, 2017

I just pushed a change that splits the long line in two.

@airalcorn2
Copy link
Contributor Author

@lesteve - yes, those look correct.

@lesteve
Copy link
Member

lesteve commented Aug 29, 2017

OK I am going to merge this hoping that it fixes the CircleCI on master.

@lesteve lesteve merged commit 026e10a into scikit-learn:master Aug 29, 2017
@lesteve
Copy link
Member

lesteve commented Aug 29, 2017

Thanks a lot!

@lesteve
Copy link
Member

lesteve commented Aug 29, 2017

CircleCI build on master is at https://circleci.com/gh/scikit-learn/scikit-learn/13152.

@airalcorn2 airalcorn2 deleted the cnb_documentation branch August 29, 2017 20:30
@lesteve
Copy link
Member

lesteve commented Aug 29, 2017

Looks like the LaTeX doc built fine on master on CircleCI, great job!

@jnothman
Copy link
Member

Thanks for the quick turnaround, @airalcorn2.

maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this pull request Nov 15, 2017
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this pull request Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants