-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
[MRG] Fix math syntax for ComplementNB documentation. #9644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you check that the equations look as you would expect in https://13148-843222-gh.circle-artifacts.com/0/home/ubuntu/scikit-learn/doc/_build/html/stable/modules/naive_bayes.html#complement-naive-bayes |
@jnothman unfortunately there is no way yet to force building the LaTeX documentation in a PR so we may as well merge this and see whether that fixes the CircleCI build error on master ... |
I just pushed a change that splits the long line in two. |
@lesteve - yes, those look correct. |
OK I am going to merge this hoping that it fixes the CircleCI on master. |
Thanks a lot! |
CircleCI build on master is at https://circleci.com/gh/scikit-learn/scikit-learn/13152. |
Looks like the LaTeX doc built fine on master on CircleCI, great job! |
Thanks for the quick turnaround, @airalcorn2. |
Attempts to fix the documentation issues brought up by @jnothman here. I was missing a curly bracket in the second fraction, which I suspect was causing the TeX issues (sorry about that). The alpha notation follows the notation in the paper where
\alpha = \sum_{i} \alpha_i
, which I now mention in the documentation. I've also slightly rearranged the equations to make it obvious that the alphas are not included in the summations.