This repository was archived by the owner on Dec 6, 2023. It is now read-only.
Do not pre-cythonize for sdist and update build scripts #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a next step we can automatically create wheel files for all platforms at GitHub Actions and upload them to PyPI. So for the majority of users (who |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to scikit-learn/scikit-learn#14863 and scikit-learn/scikit-learn#15567.
This PR reverts this part of #108.
Creating archive with source files works and that archive is installable ✔️
https://github.com/StrikerRUS/lightning/commit/d7428e8bffe44f03eebb6dfd5d611d2c21a63a26
https://github.com/StrikerRUS/lightning/actions/runs/886802731
Creating wheel file works and that wheel is installable ✔️
https://github.com/StrikerRUS/lightning/commit/4c5b9479f441d1a45c29656068bed025d7542be7
https://github.com/StrikerRUS/lightning/actions/runs/886822240