Skip to content

[MRG] Documentation: introduction to metric learning #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 7, 2019

Conversation

bellet
Copy link
Member

@bellet bellet commented Jan 3, 2019

This PR improves the documentation by adding a proper section introducing metric learning (problem setting, mahalanobis distance, use cases and general references). A small description of the package is also added to the index page for clarity.

@bellet
Copy link
Member Author

bellet commented Jan 3, 2019

I still need to write a few lines about use-cases.

Note that I also commented out the part listing the class methods: I think it would be better to move this to the supervised and weakly supervised sections, within a proper 'API' subsection

@bellet bellet changed the title Documentation: introduction to metric learning [WIP] Documentation: introduction to metric learning Jan 3, 2019
@bellet bellet changed the title [WIP] Documentation: introduction to metric learning [MRG] Documentation: introduction to metric learning Jan 4, 2019
@bellet
Copy link
Member Author

bellet commented Jan 4, 2019

This should be ready to merge - feedback is welcome.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@wdevazelhes wdevazelhes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's great !

@wdevazelhes
Copy link
Member

Note that I also commented out the part listing the class methods: I think it would be better to move this to the supervised and weakly supervised sections, within a proper 'API' subsection

Yes I agree, the current 'Package overview' subsection is currently not organized. We could add these comment lines, plus also organize the sections a bit (like separate weakly supervised algos from supervised etc). I'll raise an issue for that

@perimosocordiae perimosocordiae merged commit d00196d into scikit-learn-contrib:master Jan 7, 2019
@perimosocordiae
Copy link
Contributor

Merged, thanks! Moving the commented-out section should be handled by gh-149.

@bellet bellet deleted the doc_maha branch January 7, 2019 16:49
@wdevazelhes wdevazelhes mentioned this pull request May 22, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants