Skip to content

Renamed Google Analytics to Google Universal Analytics #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

nick-Ag
Copy link
Member

@nick-Ag nick-Ag commented Oct 21, 2021

Proposed changes

This PR renames our Google Analytics to Google Universal Analytics in our docs since we are renaming the destination to Google Universal Analytics. I found and replaced all instances of 'Google Analytics' to 'Google Universal Analytics' except for 'Google Analytics 4' or similar items. I also went thru the git diff and checked each change to make sure it makes sense.

Merge timing

This PR should be merged:

  • After change freeze ends tomorrow &&
  • Immediately after the destination is renamed in production

Fixed some strings that were misspelled or should have not been switched to Google Universal Analytics
@nick-Ag nick-Ag marked this pull request as ready for review October 22, 2021 16:53
@nick-Ag nick-Ag requested a review from a team as a code owner October 22, 2021 16:53
@nick-Ag nick-Ag requested review from markzegarelli, lcampos, mericsson, marinhero, rvadera12 and brennan and removed request for a team October 22, 2021 16:53
@@ -1,5 +1,5 @@
---
title: Google Analytics Destination
title: Google Universal Analytics Destination
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know if the name in the header confers any special functionality? Could changing it affect or break anything? May not be an issue at all - just curious. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brennan Changing that name will not break any functionality. The titles in Nav items are in a different file, which I'll add to this PR.

@nick-Ag
Copy link
Member Author

nick-Ag commented Oct 25, 2021

Going to wait until the sev 0 is mitigated before merging this, since Google Analytics was affected

@markzegarelli
Copy link
Contributor

@nick-Ag Is this good to merge? We are deploying docs this morning. Otherwise, we can do it next Tuesday.

@nick-Ag
Copy link
Member Author

nick-Ag commented Oct 28, 2021

@nick-Ag Is this good to merge? We are deploying docs this morning. Otherwise, we can do it next Tuesday.

Hey this is ready to merge right now, unless it's blocked by the docs deploy?

@nick-Ag nick-Ag merged commit 2a6330e into develop Oct 28, 2021
@nick-Ag nick-Ag deleted the rename-google-analytics branch October 28, 2021 20:40
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants