-
Notifications
You must be signed in to change notification settings - Fork 363
Renamed Google Analytics to Google Universal Analytics #2058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed some strings that were misspelled or should have not been switched to Google Universal Analytics
@@ -1,5 +1,5 @@ | |||
--- | |||
title: Google Analytics Destination | |||
title: Google Universal Analytics Destination |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know if the name in the header confers any special functionality? Could changing it affect or break anything? May not be an issue at all - just curious. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brennan Changing that name will not break any functionality. The titles in Nav items are in a different file, which I'll add to this PR.
Going to wait until the sev 0 is mitigated before merging this, since Google Analytics was affected |
@nick-Ag Is this good to merge? We are deploying docs this morning. Otherwise, we can do it next Tuesday. |
Hey this is ready to merge right now, unless it's blocked by the docs deploy? |
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
This PR renames our Google Analytics to Google Universal Analytics in our docs since we are renaming the destination to Google Universal Analytics. I found and replaced all instances of 'Google Analytics' to 'Google Universal Analytics' except for 'Google Analytics 4' or similar items. I also went thru the git diff and checked each change to make sure it makes sense.
Merge timing
This PR should be merged: