clean up build command #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknight12882
suggested changes
Oct 7, 2019
| @@ -17,7 +17,7 @@ intialize-work-dir: | |||
|
|
|||
| .PHONY: build | |||
| build: node_modules vendor/bundle | |||
| # @bundle exec rake catalog:update | |||
| @chown -R jekyll /workdir | |||
There was a problem hiding this comment.
I don't understand the need for this line
There was a problem hiding this comment.
The Jekyl docker container has some permission issues due to the default User identity it uses: envygeeks/jekyll-docker#116
Updating the permissions on the working directory resolves permission issues with running commands in working dir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Change build step to run in one command
Related issues (optional)