fix: add label(s) without success comment if successComment is false #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gr2m Please review |
zigang93
approved these changes
Aug 29, 2022
gr2m
requested changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
successCommentandreleasedLabelsbehaviour are not decoupled.My team is currently using this and wish to label each released issue with latest release version, so that we could filter out issues based on release version on the labels when working with GitHub's Project V2 automation workflow.
However, the
successCommenton multiple issues will trigger a lot of emails and GitHub Teams App notifications, which we would like to turn off to avoid annoying notification spamming.This PR removes the coupling between
successCommentandreleasedLabels, so that user could feel free to add labels without the bot comments.close #421