Skip to content

fix: decouple successComment and releasedLabels when successComment is false #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

june21x
Copy link

@june21x june21x commented Sep 12, 2022

close #421
reopened from PR #532

@june21x
Copy link
Author

june21x commented Sep 12, 2022

Hi @gr2m , I have reopened the PR.
Any help on review and merge is appreciated, thanks.

@zigang93
Copy link

zigang93 commented Jan 18, 2023

Hi @gr2m , can you have a look on this PR?

Copy link

@aslafy-z aslafy-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I'd like the tests to be run, not sure what's prevent it. Can you have a look @travi? Thanks!

@aslafy-z
Copy link

aslafy-z commented Apr 12, 2023

@travi @gr2m any updates please?

@june21x june21x closed this Nov 21, 2023
@june21x june21x force-pushed the decouple-success-comment-labels branch from 4c3108b to 863fcb6 Compare November 21, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disabling successComment but adding releasedLabels
3 participants