Fix exception when merging with empty commit message (backport) #391
Conversation
Fixes sigmavirus24#370 The GitHub API now requires a param `commit_message` with an empty value '' when merging a pull request. In such case the default value is used as a commit message. Providing an empty data string no longer works. (cherry picked from commit 39c06c9) Conflicts: tests/unit/test_pulls.py The test file was not backported because it doesn't exist on the destination branch.
|
Waiting for the build to go green. 💃 Thank you! |
|
I will fix the tests tonight when I can access to a proper environment and update the pull-request. |
|
@antoine-g that's not a cassette failure. That's the old-style tests which are just awful. If you wouldn't mind, could you look at the develop branch and backport some of the unit tests for the Cheers, |
The backport of the change didn't include the unit test as it was not mergeable. This commit fixes the execution of the test with the new behaviour.
|
It turns out that it was easier to fix this test than backporting some tests from I can try to extract only the new relevant test and remove the old one if you prefer. |
|
That's fine. Thanks @antoine-g |
Fix exception when merging with empty commit message (backport)
This pull-request backports #390 to
stable/0.9.Commit message:
Fixes #370
The GitHub API now requires a param
commit_messagewith an empty value when merging a pull request. In such case the default value is used as a commit message.Providing an empty data string no longer works.
(cherry picked from commit 39c06c9)
Conflicts:
tests/unit/test_pulls.py
The test file was not backported because it doesn't exist on the destination branch.