oauth: Fix race in OIDC token retrieval #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
9d856b6 to
881ccbb
Compare
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
|
The issue is that sometimes the browser requests |
woodruffw
reviewed
May 31, 2022
sigstore/_internal/oidc/oauth.py
Outdated
| # If the auth response has already been populated, the main thread will be stopping this | ||
| # thread and accessing the auth response shortly so we should stop servicing any requests. | ||
| if not server.active: | ||
| return |
There was a problem hiding this comment.
return None here and below? I'm surprised our linting tools don't enforce this...
|
Nice debugging! Yeah, that's an interesting error case. I believe the GIL unfortunately does not prevent write tearing -- it really only protects the integrity of the interpreter itself 😞 |
di
previously approved these changes
May 31, 2022
Signed-off-by: William Woodruff <william@trailofbits.com>
woodruffw
approved these changes
May 31, 2022
javanlacerda
pushed a commit
to javanlacerda/sigstore-python
that referenced
this pull request
Feb 23, 2024
* Make it easier to run verification test locally For sigstore#99 If you're only testing verification use-cases locally, you don't need the OIDC JWT. Signed-off-by: Zach Steindler <steiza@github.com> * Nicer error message for not providing arguments ``` sigstore-conformance$ pytest test --entrypoint /Users/steiza/code/steiza/sigstore-conformance/sigstore-python-conformance Please specify one of '--github-token' or '--skip-signing' sigstore-conformance$ echo $? 3 ``` Signed-off-by: Zach Steindler <steiza@github.com> --------- Signed-off-by: Zach Steindler <steiza@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96