-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Obtainium icon #11451
Add Obtainium icon #11451
Conversation
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't use the icon from the GitHub repo as source but the SVG icon from the official website which is a completely different SVG. If you think that the icon from the GitHub repo should be used as source instead, I could rework the icon. What do you think @mondeja? |
I would prefer us to use the Github version of the icon, specifically this link so we maintain a view of the versioning of the file. |
Used the link as source and optimized the icon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @CodeShakingSheep!
## 10 new icons - AFDIAN (#12315) (@Zuoqiu-Yingyi) - CSS (#12134) (@LitoMore) - D3 (#12368) (@service-paradis) - Deutsche Telekom (#11912) (@DerBraky) - Nuxt (#12369) (@service-paradis) - Obtainium (#11451) (@CodeShakingSheep) - QQ (#12218) (@LitoMore) - start.gg (#12115) (@rushikeshtagadkar) - Tuta (#12081) (@DerBraky) - YouHodler (#11171) (@CodeShakingSheep) ## 4 updated icons - .NET (#12372) (@adamrusted) - Coca-Cola (#12358) (@rushikeshtagadkar) - Creative Commons (#12392) (@adamrusted) - Private Internet Access (#12370) (@service-paradis) ## 59 removed icons - Adobe (#10018) (@adamrusted) - Adobe Acrobat Reader (#10018) (@adamrusted) - Adobe After Effects (#10018) (@adamrusted) - Adobe Audition (#10018) (@adamrusted) - Adobe Creative Cloud (#10018) (@adamrusted) - Adobe Dreamweaver (#10018) (@adamrusted) - Adobe Fonts (#10018) (@adamrusted) - Adobe Illustrator (#10018) (@adamrusted) - Adobe InDesign (#10018) (@adamrusted) - Adobe Lightroom (#10018) (@adamrusted) - Adobe Lightroom Classic (#10018) (@adamrusted) - Adobe Photoshop (#10018) (@adamrusted) - Adobe Premiere Pro (#10018) (@adamrusted) - Adobe XD (#10018) (@adamrusted) - ASKfm (#12401) (@service-paradis) - Caffeine (#12210) (@mondeja) - CKEditor 4 (#11555) (@uncenter) - Cliqz (#11411) (@dipenmagdani) - Coil (#12209) (@mondeja) - D3.js (#12368) (@service-paradis) - del.icio.us (#12211) (@mondeja) - El Jueves (#12237) (@mondeja) - Ello (#12199) (@mondeja) - FeatHub (#11634) (@CodeShakingSheep) - Fluxus (#12206) (@mondeja) - Foursquare City Guide (#12331) (@LitoMore) - Funimation (#12200) (@mondeja) - Game & Watch (#12379) (@LitoMore) - Géant (#12231) (@mondeja) - Katacoda (#12229) (@mondeja) - LinkedIn (#11380) (@vanshaj-sharma) - Magento (#10018) (@adamrusted) - Marketo (#12230) (@mondeja) - Microgenetics (#12207) (@mondeja) - Nintendo (#12379) (@LitoMore) - Nintendo 3DS (#12379) (@LitoMore) - Nintendo DS (#12379) (@LitoMore) - Nintendo GameCube (#12379) (@LitoMore) - Nintendo Switch (#12379) (@LitoMore) - Nuxt.js (#12369) (@service-paradis) - Oracle (#11843) (@adamrusted) - Pokémon (#12379) (@LitoMore) - RadioPublic (#12208) (@mondeja) - Realm (#12201) (@mondeja) - Revue (#12204) (@mondeja) - Skyrock (#12198) (@mondeja) - smash.gg (#12115) (@rushikeshtagadkar) - Spinrilla (#12205) (@mondeja) - StackPath (#12227) (@mondeja) - Stitcher (#11693) (@oyezaheer) - Studyverse (#12164) (@LitoMore) - T-Mobile (#11912) (@DerBraky) - Tableau (#12212) (@mondeja) - Tencent QQ (#12218) (@LitoMore) - Tutanota (#12081) (@DerBraky) - Uptobox (#12197) (@mondeja) - Wii (#12379) (@LitoMore) - Wii U (#12379) (@LitoMore) - Zerply (#11388) (@SnehalSrivastava27) ## SDK breaking changes ### `_data/simple-icons.json` file structure updated The `icons` property has been dropped. Now the JSON content is the array of icons. ```diff import {getIconsData} from 'simple-icons/sdk'; const iconsData = await getIconsData(); -const icons = iconsData.icons; +const icons = iconsData; ``` ### `getIconDataPath()` has been renamed to `getIconsDataPath()` We renamed this function to make our function names consistent. ```diff -import {getIconDataPath} from 'simple-icons/sdk'; +import {getIconsDataPath} from 'simple-icons/sdk'; ```
Issue: closes #11418
Popularity metric:
Obtainium has ~6k GitHub stars. See https://github.com/ImranR98/Obtainium
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
I used the website's text color as brand color.