Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Obtainium icon #11451

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

CodeShakingSheep
Copy link
Contributor

image

Issue: closes #11418

Popularity metric:

Obtainium has ~6k GitHub stars. See https://github.com/ImranR98/Obtainium

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

I used the website's text color as brand color.

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label Jul 10, 2024
@DerBraky
Copy link
Contributor

Thank you!

Copy link
Member

@mondeja mondeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source in issue #11418 (violet) has so many less points than your version (black):

image

Please, optimize the path.

@CodeShakingSheep
Copy link
Contributor Author

The source in issue #11418 (violet) has so many less points than your version (black):

Please, optimize the path.

I didn't use the icon from the GitHub repo as source but the SVG icon from the official website which is a completely different SVG. If you think that the icon from the GitHub repo should be used as source instead, I could rework the icon. What do you think @mondeja?

@adamrusted
Copy link
Member

I would prefer us to use the Github version of the icon, specifically this link so we maintain a view of the versioning of the file.

@CodeShakingSheep
Copy link
Contributor Author

I would prefer us to use the Github version of the icon, specifically this link so we maintain a view of the versioning of the file.

Used the link as source and optimized the icon.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @CodeShakingSheep!

@adamrusted adamrusted merged commit a1ffeff into simple-icons:develop Dec 17, 2024
3 checks passed
@CodeShakingSheep CodeShakingSheep deleted the add-obtanium-icon branch December 17, 2024 14:59
simple-icons bot added a commit that referenced this pull request Dec 22, 2024
## 10 new icons

- AFDIAN (#12315) (@Zuoqiu-Yingyi)
- CSS (#12134) (@LitoMore)
- D3 (#12368) (@service-paradis)
- Deutsche Telekom (#11912) (@DerBraky)
- Nuxt (#12369) (@service-paradis)
- Obtainium (#11451) (@CodeShakingSheep)
- QQ (#12218) (@LitoMore)
- start.gg (#12115) (@rushikeshtagadkar)
- Tuta (#12081) (@DerBraky)
- YouHodler (#11171) (@CodeShakingSheep)

## 4 updated icons

- .NET (#12372) (@adamrusted)
- Coca-Cola (#12358) (@rushikeshtagadkar)
- Creative Commons (#12392) (@adamrusted)
- Private Internet Access (#12370) (@service-paradis)

## 59 removed icons

- Adobe (#10018) (@adamrusted)
- Adobe Acrobat Reader (#10018) (@adamrusted)
- Adobe After Effects (#10018) (@adamrusted)
- Adobe Audition (#10018) (@adamrusted)
- Adobe Creative Cloud (#10018) (@adamrusted)
- Adobe Dreamweaver (#10018) (@adamrusted)
- Adobe Fonts (#10018) (@adamrusted)
- Adobe Illustrator (#10018) (@adamrusted)
- Adobe InDesign (#10018) (@adamrusted)
- Adobe Lightroom (#10018) (@adamrusted)
- Adobe Lightroom Classic (#10018) (@adamrusted)
- Adobe Photoshop (#10018) (@adamrusted)
- Adobe Premiere Pro (#10018) (@adamrusted)
- Adobe XD (#10018) (@adamrusted)
- ASKfm (#12401) (@service-paradis)
- Caffeine (#12210) (@mondeja)
- CKEditor 4 (#11555) (@uncenter)
- Cliqz (#11411) (@dipenmagdani)
- Coil (#12209) (@mondeja)
- D3.js (#12368) (@service-paradis)
- del.icio.us (#12211) (@mondeja)
- El Jueves (#12237) (@mondeja)
- Ello (#12199) (@mondeja)
- FeatHub (#11634) (@CodeShakingSheep)
- Fluxus (#12206) (@mondeja)
- Foursquare City Guide (#12331) (@LitoMore)
- Funimation (#12200) (@mondeja)
- Game & Watch (#12379) (@LitoMore)
- Géant (#12231) (@mondeja)
- Katacoda (#12229) (@mondeja)
- LinkedIn (#11380) (@vanshaj-sharma)
- Magento (#10018) (@adamrusted)
- Marketo (#12230) (@mondeja)
- Microgenetics (#12207) (@mondeja)
- Nintendo (#12379) (@LitoMore)
- Nintendo 3DS (#12379) (@LitoMore)
- Nintendo DS (#12379) (@LitoMore)
- Nintendo GameCube (#12379) (@LitoMore)
- Nintendo Switch (#12379) (@LitoMore)
- Nuxt.js (#12369) (@service-paradis)
- Oracle (#11843) (@adamrusted)
- Pokémon (#12379) (@LitoMore)
- RadioPublic (#12208) (@mondeja)
- Realm (#12201) (@mondeja)
- Revue (#12204) (@mondeja)
- Skyrock (#12198) (@mondeja)
- smash.gg (#12115) (@rushikeshtagadkar)
- Spinrilla (#12205) (@mondeja)
- StackPath (#12227) (@mondeja)
- Stitcher (#11693) (@oyezaheer)
- Studyverse (#12164) (@LitoMore)
- T-Mobile (#11912) (@DerBraky)
- Tableau (#12212) (@mondeja)
- Tencent QQ (#12218) (@LitoMore)
- Tutanota (#12081) (@DerBraky)
- Uptobox (#12197) (@mondeja)
- Wii (#12379) (@LitoMore)
- Wii U (#12379) (@LitoMore)
- Zerply (#11388) (@SnehalSrivastava27)

## SDK breaking changes

### `_data/simple-icons.json` file structure updated

The `icons` property has been dropped. Now the JSON content is the array of icons.

```diff
import {getIconsData} from 'simple-icons/sdk';

const iconsData = await getIconsData();
-const icons = iconsData.icons;
+const icons = iconsData;
```

### `getIconDataPath()` has been renamed to `getIconsDataPath()`

We renamed this function to make our function names consistent.

```diff
-import {getIconDataPath} from 'simple-icons/sdk';
+import {getIconsDataPath} from 'simple-icons/sdk';
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Obtanium
5 participants