.gitignore Manifest, remove Plots and UMAP from TopicModels deps, com… #10
Conversation
examples/LDA.jl
Outdated
| @@ -1,4 +1,4 @@ | |||
| using TopicModels, Plots, UMAP | |||
| using TopicModels, Plots | |||
There was a problem hiding this comment.
Isn't plots still being used here?
There was a problem hiding this comment.
Yes, but since there is no "suggests" functionality in the Pkg ecosystem, it seemed better style to omit packages that aren't required at compile time. I've noticed other projects (eg https://turing.ml/dev/tutorials/3-bayesnn/) take the same approach regarding deps that exist solely in examples from the documentation. Does that seem reasonable?
Project.toml
Outdated
| @@ -6,10 +6,9 @@ version = "0.1.0" | |||
| [deps] | |||
| Clustering = "aaaa29a8-35af-508c-8bc3-b662a17a0fe5" | |||
| Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f" | |||
| Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80" | |||
| NearestNeighborDescent = "dd2c4c9e-a32f-5b2f-b342-08c2f244fce8" | |||
There was a problem hiding this comment.
Sorry, NearestNeighborDescent should have been removed. it's a dep for a recently updated version of UMAP.jl that I was testing earlier. I can re-submit the PR with correct Project.toml. Incidentally, the latest version of UMAP.jl does seem to work, but I'd still be more comfortable leaving it commented in examples.
There was a problem hiding this comment.
Cool, if you could just update this PR with the updated NN dependencies removed, the rest of what you said makes sense.
Resolved issues with manifest, commented some example plotting due to breaking changes in UMAP
Added runtests.jl+include()'s so that automated testing in Pkg works
NB after checking this out, do:
to regenerate correct Manifest