Skip to content

Test against 2023.2 #4446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 1, 2023
Merged

Test against 2023.2 #4446

merged 11 commits into from
Dec 1, 2023

Conversation

AlecKazakova
Copy link
Collaborator

No description provided.

@hfhbd
Copy link
Collaborator

hfhbd commented Jul 28, 2023 

Plugin com.squareup.sqldelight:2.1.0-SNAPSHOT-1690451470735 against IC-232.8660.185: 3 compatibility problems. 10 usages of scheduled for removal API and 16 usages of deprecated API. 6 usages of experimental API. 11 usages of internal API
Compatibility problems (3): 
    #Invocation of unresolved constructor com.intellij.mock.MockModule.<init>(Project, Disposable)
        Constructor app.cash.sqldelight.core.SqlDelightEnvironment.<init>(app.cash.sqldelight.core.SqlDelightDatabaseProperties properties, app.cash.sqldelight.core.SqlDelightCompilationUnit compilationUnit, boolean verifyMigrations, app.cash.sqldelight.dialect.api.SqlDelightDialect dialect, java.lang.String moduleName, java.util.List sourceFolders, java.util.List dependencyFolders) contains an *invokespecial* instruction referencing an unresolved constructor com.intellij.mock.MockModule.<init>(com.intellij.openapi.project.Project, com.intellij.openapi.Disposable). This can lead to **NoSuchMethodError** exception at runtime.
    #Access to unresolved field org.jetbrains.kotlin.idea.stubindex.KotlinClassShortNameIndex.INSTANCE : KotlinClassShortNameIndex
        Method app.cash.sqldelight.intellij.util.PsiClassSearchHelper.getClassesByShortName(java.lang.String shortName, com.intellij.openapi.project.Project project, com.intellij.psi.search.GlobalSearchScope scope) : java.util.List contains a *getstatic* instruction referencing an unresolved field org.jetbrains.kotlin.idea.stubindex.KotlinClassShortNameIndex.INSTANCE : org.jetbrains.kotlin.idea.stubindex.KotlinClassShortNameIndex. This can lead to **NoSuchFieldError** exception at runtime.
        The field might have been declared in the super classes or in the super interface:
          com.intellij.psi.stubs.AbstractStubIndex
          com.intellij.psi.stubs.StringStubIndexExtension
          com.intellij.psi.stubs.StubIndexExtension
    #Access to unresolved field org.jetbrains.kotlin.idea.stubindex.KotlinTopLevelTypeAliasFqNameIndex.INSTANCE : KotlinTopLevelTypeAliasFqNameIndex
        Method app.cash.sqldelight.intellij.SqlDelightReferenceContributor.JavaTypeReference.resolve.typeAlias$1.invoke() : org.jetbrains.kotlin.psi.KtTypeAlias contains a *getstatic* instruction referencing an unresolved field org.jetbrains.kotlin.idea.stubindex.KotlinTopLevelTypeAliasFqNameIndex.INSTANCE : org.jetbrains.kotlin.idea.stubindex.KotlinTopLevelTypeAliasFqNameIndex. This can lead to **NoSuchFieldError** exception at runtime.
        The field might have been declared in the super classes or in the super interface:
          com.intellij.psi.stubs.AbstractStubIndex
          com.intellij.psi.stubs.StringStubIndexExtension
          com.intellij.psi.stubs.StubIndexExtension

@AlecKazakova
Copy link
Collaborator Author

yea that one is interesting because a companion object had its name changed between versions, so we're API compatible but technically not ABI compatible? But when I run the plugin on 2023.2 it appears to work, so we are ABI compatible??? I don't really understand

@aperfilyev
Copy link
Collaborator

#Invocation of unresolved constructor com.intellij.mock.MockModule.<init>(Project, Disposable)

I've stumbled upon this too. If we look into source, the constructor parameter was changed from Project to MockProject which is in fact implements Project and I have no idea why that won't work

@AlecKazakova
Copy link
Collaborator Author

The Mock stuff is also only invoked from the gradle plugin, but we have it in the compiler module in order to run unit tests.

I think we could move SqlDelightEnvironment and its dependencies into the gradle plugin source, and depend on the gradle plugin just from the compiler test configuration. Gets rid of that compatibility issue and any future ones around using the Mock IJ types from the IJ plugin

AlecKazakova and others added 10 commits October 19, 2023 11:56
@AlecKazakova
Merge branch 'master' into astrong/2023-07-27/test-2023-2
7846c4b
@AlecKazakova
Merge branch 'master' into astrong/2023-07-27/test-2023-2
d41833d
@renovate @AlecKazakova
Update dependency mkdocs-material-extensions to v1.3.1 (#4832)
8fe9018 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @AlecKazakova
Update dependency com.squareup:kotlinpoet to v1.15.2 (#4855)
79877e5 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@hfhbd @AlecKazakova
Bump sql-psi to 0.5.0 (#4794)
0d035c4 
* Bump sql-psi to 0.5.0-SNAPSHOT

* Use published loadFolderFromResources function

* Expose HSQL test-fixtures

* Expose MySql test-fixtures

* Move timber from sql-psi to sqldelight

* Expose Sqlite Json test-fixtures

* Expose Sqlite 3.18 test-fixtures

* Expose Sqlite 3.24 test-fixtures

* Expose Sqlite 3.25 test-fixtures

* Expose Sqlite 3.30 test-fixtures

* Expose Sqlite 3.33 test-fixtures

* Expose Sqlite 3.35 test-fixtures

* Expose Sqlite 3.38 test-fixtures

* Spotless

* Adopt changed sql-psi api

* Add snapshot repo to test snapshot

* Fix Infer between

* Add missing snapshot repo

* Add missing snapshot repo

* Switch to the release version

* Use new loadFolderFromResources shortcut

---------

Co-authored-by: hfhbd <hfhbd@users.noreply.github.com>
@de-luca @AlecKazakova
Add TRUNCATE to postgres dialect (#4817)
a8d90da 
Co-authored-by: Alec Kazakova <1675456+AlecKazakova@users.noreply.github.com>
@MohamadJaara @AlecKazakova
feat: add initialOffset for OffsetQueryPagingSource (#4802)
b68f466 
* feat: add initialOffset for OffsetQueryPagingSource

* apply spotless check

* binary compatibility overload

* typo

* add @jvmoverloads for ABI compatibility

* add @jvmoverloads for ABI compatibility
@renovate @AlecKazakova
Update agp to v8.2.0 (#4861)
3278962 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @AlecKazakova
Update plugin intellij to v1.16.1 (#4862)
c7d01da 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@AlecKazakova
Fix compatibility issues
bfea438
@AlecKazakova AlecKazakova force-pushed the astrong/2023-07-27/test-2023-2 branch from c023262 to bfea438 Compare December 1, 2023 17:27
@AlecKazakova AlecKazakova merged commit 471afc4 into master Dec 1, 2023
@AlecKazakova AlecKazakova deleted the astrong/2023-07-27/test-2023-2 branch December 1, 2023 18:06
hfhbd added a commit that referenced this pull request Apr 2, 2024
@AlecKazakova @renovate
@hfhbd @de-luca @MohamadJaara
Test against 2023.2 (#4446)
b351bc4 
* Test against 2023.2

* Update dependency mkdocs-material-extensions to v1.3.1 (#4832)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update dependency com.squareup:kotlinpoet to v1.15.2 (#4855)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Bump sql-psi to 0.5.0 (#4794)

* Bump sql-psi to 0.5.0-SNAPSHOT

* Use published loadFolderFromResources function

* Expose HSQL test-fixtures

* Expose MySql test-fixtures

* Move timber from sql-psi to sqldelight

* Expose Sqlite Json test-fixtures

* Expose Sqlite 3.18 test-fixtures

* Expose Sqlite 3.24 test-fixtures

* Expose Sqlite 3.25 test-fixtures

* Expose Sqlite 3.30 test-fixtures

* Expose Sqlite 3.33 test-fixtures

* Expose Sqlite 3.35 test-fixtures

* Expose Sqlite 3.38 test-fixtures

* Spotless

* Adopt changed sql-psi api

* Add snapshot repo to test snapshot

* Fix Infer between

* Add missing snapshot repo

* Add missing snapshot repo

* Switch to the release version

* Use new loadFolderFromResources shortcut

---------

Co-authored-by: hfhbd <hfhbd@users.noreply.github.com>

* Add TRUNCATE to postgres dialect (#4817)

Co-authored-by: Alec Kazakova <1675456+AlecKazakova@users.noreply.github.com>

* feat: add initialOffset for OffsetQueryPagingSource (#4802)

* feat: add initialOffset for OffsetQueryPagingSource

* apply spotless check

* binary compatibility overload

* typo

* add @jvmoverloads for ABI compatibility

* add @jvmoverloads for ABI compatibility

* Update agp to v8.2.0 (#4861)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update plugin intellij to v1.16.1 (#4862)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Fix compatibility issues

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Philip Wedemann <22521688+hfhbd@users.noreply.github.com>
Co-authored-by: hfhbd <hfhbd@users.noreply.github.com>
Co-authored-by: Bastien de Luca <de-luca@users.noreply.github.com>
Co-authored-by: Mohamad Jaara <jaara.moh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWharton JakeWharton JakeWharton approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AlecKazakova @hfhbd @aperfilyev @JakeWharton @de-luca @MohamadJaara