fix: change QueryPagingSource() parameter order to support trailing l… #5585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ambda syntax again Fixes sqldelight#4869
c3eb0d5 to
75d09ae
Compare
|
Tests failed because IDE reformatted lines during automated refactor. Fixed. |
|
This seems like a binary-incompatible change, though. |
I believe so. The original PR #4802 from 2.0.1 forced me to refactor my code due to moving the lambda in the wrong place, despite alleged binary compatibility from Not sure why the original PR did not use this order, wouldn't that have equally retained binary compatibility at the time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ambda syntax again
Fixes #4869