Skip to content

chore: fix EditorConfig lint errors #5534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 25 commits into from
Closed

Conversation

ditsus
Copy link
Contributor

@ditsus ditsus commented Mar 1, 2025

Resolves #5423.

Description

What is the purpose of this pull request?

The purpose of this pull request is to fix EditorConfig linting issues with spaces and indents in the following files:

lib/node_modules/@stdlib/_tools/eslint/rules/no-nested-require/examples/index.js
lib/node_modules/@stdlib/math/base/special/rsqrt/manifest.json
lib/node_modules/@stdlib/ndarray/base/strides2offset/manifest.json

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 1, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 1, 2025
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

stdlib-bot and others added 5 commits February 28, 2025 20:32
PR-URL: stdlib-js#5533
Reviewed-by: Athan Reines <kgryte@gmail.com>
PR-URL: stdlib-js#5523
Closes: stdlib-js#5503
Reviewed-by: Athan Reines <kgryte@gmail.com>
PR-URL: stdlib-js#5540
Reviewed-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
PR-URL: stdlib-js#5531
Reviewed-by: Athan Reines <kgryte@gmail.com>
PR-URL: stdlib-js#5541
Reviewed-by: Athan Reines <kgryte@gmail.com>
'endLine': 2,
'endColumn': 29
}
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
]
]

]
}
]
"options": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our EditorConfig configuration, please use two-space indentation in all JSON files. See

indent_size = 2
.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 1, 2025
anandkaranubc and others added 14 commits February 28, 2025 23:07
PR-URL: stdlib-js#5544
Reviewed-by: Athan Reines <kgryte@gmail.com>
PR-URL: stdlib-js#5545
Reviewed-by: Athan Reines <kgryte@gmail.com>
PR-URL: stdlib-js#5546
Reviewed-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
PR-URL: stdlib-js#5397

Reviewed-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
…c/skewness`

PR-URL: stdlib-js#4560
Ref: stdlib-js#3666

Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
…c/stdev`

PR-URL: stdlib-js#4559
Closes: stdlib-js#3667

Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
PR-URL: stdlib-js#5539

Signed-off-by: dependabot[bot] <support@github.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR-URL: stdlib-js#5535

Signed-off-by: dependabot[bot] <support@github.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR-URL: stdlib-js#5538

Signed-off-by: dependabot[bot] <support@github.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR-URL: stdlib-js#5537

Signed-off-by: dependabot[bot] <support@github.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR-URL: stdlib-js#5536

Signed-off-by: dependabot[bot] <support@github.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR-URL: stdlib-js#4898
Closes: stdlib-js#4897

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Mar 4, 2025
@Planeshifter Planeshifter added the autoclose: Git History Pull request which should be auto-closed due to a messed-up Git history. label Mar 4, 2025
@stdlib-bot
Copy link
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution due to Git history issues.

Some common issues include:

  • Merge conflicts
  • Inappropriate commit messages
  • Unrelated commits
  • Including changes from merged branches that weren't intended for this PR

We recommend opening a new pull request with only the intended changes.

Thank you for your interest in stdlib, and we look forward to your future contributions.

@stdlib-bot stdlib-bot closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoclose: Git History Pull request which should be auto-closed due to a messed-up Git history. Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors
8 participants