-
-
Notifications
You must be signed in to change notification settings - Fork 813
chore: fix EditorConfig lint errors #5534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
PR-URL: stdlib-js#5533 Reviewed-by: Athan Reines <kgryte@gmail.com>
PR-URL: stdlib-js#5523 Closes: stdlib-js#5503 Reviewed-by: Athan Reines <kgryte@gmail.com>
PR-URL: stdlib-js#5540 Reviewed-by: Athan Reines <kgryte@gmail.com> Co-authored-by: stdlib-bot <noreply@stdlib.io>
PR-URL: stdlib-js#5531 Reviewed-by: Athan Reines <kgryte@gmail.com>
PR-URL: stdlib-js#5541 Reviewed-by: Athan Reines <kgryte@gmail.com>
'endLine': 2, | ||
'endColumn': 29 | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
] | |
] |
] | ||
} | ||
] | ||
"options": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per our EditorConfig configuration, please use two-space indentation in all JSON files. See
Line 46 in 183d056
indent_size = 2 |
PR-URL: stdlib-js#5544 Reviewed-by: Athan Reines <kgryte@gmail.com>
PR-URL: stdlib-js#5545 Reviewed-by: Athan Reines <kgryte@gmail.com>
PR-URL: stdlib-js#5546 Reviewed-by: Athan Reines <kgryte@gmail.com> Co-authored-by: stdlib-bot <noreply@stdlib.io>
PR-URL: stdlib-js#5397 Reviewed-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
…c/skewness` PR-URL: stdlib-js#4560 Ref: stdlib-js#3666 Co-authored-by: stdlib-bot <noreply@stdlib.io> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
…c/stdev` PR-URL: stdlib-js#4559 Closes: stdlib-js#3667 Co-authored-by: stdlib-bot <noreply@stdlib.io> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---
PR-URL: stdlib-js#5539 Signed-off-by: dependabot[bot] <support@github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR-URL: stdlib-js#5535 Signed-off-by: dependabot[bot] <support@github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR-URL: stdlib-js#5538 Signed-off-by: dependabot[bot] <support@github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR-URL: stdlib-js#5537 Signed-off-by: dependabot[bot] <support@github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR-URL: stdlib-js#5536 Signed-off-by: dependabot[bot] <support@github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR-URL: stdlib-js#4898 Closes: stdlib-js#4897 Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Thank you for working on this pull request. However, we cannot accept your contribution due to Git history issues. Some common issues include:
We recommend opening a new pull request with only the intended changes. Thank you for your interest in stdlib, and we look forward to your future contributions. |
Resolves #5423.
Description
The purpose of this pull request is to fix EditorConfig linting issues with spaces and indents in the following files:
lib/node_modules/@stdlib/_tools/eslint/rules/no-nested-require/examples/index.js
lib/node_modules/@stdlib/math/base/special/rsqrt/manifest.json
lib/node_modules/@stdlib/ndarray/base/strides2offset/manifest.json
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers