sai: sai_v1 patch and sai peripheral apply to H7. Fix FSDEF #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SAI peripheral applies to the H7 also. Note that we introduce the very slightest difference with RM0433 (single core 743/753) by setting `[AB]CR1.NOMCK` -> `[AB]CR1.NODIV`. Both RM0399 (later dual core parts) and `sai/sai.py` use NODIV. The description in `sai/sai.py` has text from both the old and new definitions, and it appears the functionality of the bit is unchanged. [AB]FRCR.FSDEF is marked as read only in the SVD and the register diagram in the RM. However, in the prose text in the RM is is clearly noted as read-write "This bit is set and cleared by software." (RM0399 rev2 page 2458).
|
Ugh, a pain that they renamed the bit. I'm a little hesitant to rename valid bits in the older devices just to match the existing peripheral file, but if this also makes life easier for HALs it might be worth doing. Any thoughts? |
|
Pragmatically the answer is to rename it for consistency, but it does break the rule of matching the best interpretation of the RM. My opinion is the RM isn't invariant either (ST release new versions!), nothing will ever be perfect, practicality wins in a trivial case like this.. |
adamgreig
approved these changes
Mar 11, 2020
Build succeeded |
richardeoin
added a commit
to richardeoin/stm32-rs
that referenced
this pull request
Oct 3, 2021
Other H7 parts are unchanged. Improve description of NOMCK/NODIV bit See previous PR stm32-rs#347. Fixes stm32-rs#618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAI peripheral applies to the H7 also. Note that we introduce the very slightest difference with RM0433 (single core 743/753) by setting
[AB]CR1.NOMCK->[AB]CR1.NODIV. Whilst RM0433 usesNOMCK, both RM0399 (later dual core parts) andsai/sai.pyuseNODIV.The description in
sai/sai.pyhas text from both the old and new definitions, and it appears the functionality of the bit is unchanged.[AB]FRCR.FSDEF is marked as read only in the SVD and the register diagram in the RM. However, in the prose text in RM0399 it is clearly noted as read-write "This bit is set and cleared by software."