H7 RM0433: Add NOMCK at SAI [AB]CR1 bit 19 and remove MCKEN #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other H7 parts are unchanged. Improve description of NOMCK/NODIV bit See previous PR stm32-rs#347. Fixes stm32-rs#618
|
What do you think of leaving the nodiv field in for these parts too, at the same offset to the nomck field? That way drivers/HAL can keep doing the same thing but users can call it by the RM name if they prefer. Maybe it's just more confusing in the end, I don't know how much the HAL really cares about this bit. |
|
The default value of nodiv is the typical use case, whilst setting it is a less common use case (I think). However the HAL does write to it a couple of times, so having nodiv at that offset for all parts would be a nice solution |
b3ef7b2 to
29fc34e
Compare
|
Thanks for the suggestion, the RM0433 parts now have both |
adamgreig
approved these changes
Oct 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other H7 parts are unchanged. Improve description of NOMCK/NODIV bit
See previous PR #347. Fixes #618