Memory map comparison

Hi, thanks for the PR!

Your changes look good, but we try to keep describing field variants (this sort of change) to the peripherals/ directory, rather than inside common_patches. In fact, it looks like all/most of the existing rcc_v3 (and rcc_v3_pll) might apply although it was originally written for the H7. It looks like you might have a few extra things not covered there, though. Perhaps you could add those (to a new file if necessary) and then include the rcc_v3 in the existing stm32g4*.yaml devices? Or if they don't quite merge, you could create a new peripherals/rcc/rcc_g4.yaml with just your changes from this PR so far, but hopefully they're similar enough that we can mostly share one definition.

Please shout if anything doesn't make sense, I know it's not the easiest thing to understand from scratch.

Gotcha; understood about the division of field variants vs field fixes (kinda sad that ST makes us fix so much, ya? :). Though I haven't gone through the H7 reference manual just yet, I did check the clock config on the STM32CubeMX and compared it to the G4's. It seems like there's enough difference - particularly in the PLL domain - that I'd be concerned with me breaking any existing H7 users by changing field names and/or APIs (divisor enums vs ranges, etc) if I were to modify the rcc_v3(_pll)? files.

I've moved the changes into a new rcc_g4.yaml file under peripherals/. Since the RCC is common to all g4 chips it's now include:'d it from the common_patches/g4_rcc.yaml file, though do let me know if that's not the right place to include it!

Memory map comparison

Thanks! Ok, fair enough on the H7 one, no problem having a new rcc_g4.yaml.

I'll try to get this fully reviewed at the weekend, but in the meantime could you move the include to be done from each device file instead of from the common_patches file? It just helps make it easier to find out where files are being included if there aren't too many layers of indirection, especially across the "patch"/"peripheral" split.

Sounds good! No hurry on the review; just have it workin' in my own local repo so I figured I'd share it with the rest of the community :)

Memory map comparison

Oof, sorry for the delay, been a nutty spring. I think I got all the requested changes, but please do double-check; was trying out the VSCode Pull Request extension and things went sideways in a hurry 😅

Memory map comparison

I've got a few more sequential updates to other various G4 peripherals. Do you prefer submitting those as individual PRs, or is one larger update better/easier to review? No preference either way :)

Build succeeded:

• Check (stm32f0)
• Check (stm32f1)
• Check (stm32f2)
• Check (stm32f3)
• Check (stm32f4)
• Check (stm32f7)
• Check (stm32g0)
• Check (stm32g4)
• Check (stm32h7)
• Check (stm32l0)
• Check (stm32l1)
• Check (stm32l4)
• Check (stm32l5)
• Check (stm32mp1)
• Check (stm32wb)
• Check (stm32wl)