Fix LCD RAM_COM register size on L4x6 #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AndreasKarg, thanks for the PR! It seems there's two groups of parts that have this "Segment LCD" peripheral:
Looking through the part table there are a couple of other parts that appear when filtering for "Segment LCD" (such as the L452) but then looking at the corresponding datasheet there's no mention of it. I'm guessing those are probably just a mistake on ST's website. So could you apply this patch to the L4x3 also? The patch itself looks good, but typically we put patches that "fix" the SVD (using _add/_modify/_delete etc) in the |
6019687 to
83a1c12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
If I understand https://www.st.com/content/st_com/en/search.html#q=lcd-t=products-page=1 and the reference manual (RM0351) right, the L4x6 is the only L4 with this LCD peripheral.
The SVDs for the 4x1, 2, 3 and 5 seem to contain the same peripheral definition though.
Due to this contradiction, I have only applied the patch to the 4x6 for now.
If someone could throw another pair of eyes on the documentation and confirm whether the other chips do or don't have this peripheral, I'm happy to update the PR and patch those as well.
If it turns out that the SVDs are wrong and the LCD peripherals don't exist, I suggest tackling that in a separate PR.