Skip to content

[stm32f7] Fix RCC registers #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 28, 2021
Merged

[stm32f7] Fix RCC registers #613

merged 4 commits into from
Sep 28, 2021

Conversation

maximeborges
Copy link
Member

Following #612, fix fields in RCC for every F7 chips

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Memory map comparison

@maximeborges maximeborges marked this pull request as draft September 1, 2021 17:13
@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Memory map comparison

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Memory map comparison

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Memory map comparison

@maximeborges maximeborges marked this pull request as ready for review September 1, 2021 17:45
@adamgreig adamgreig mentioned this pull request Sep 6, 2021
Closed
10 tasks
@github-actions
Copy link

github-actions bot commented Sep 7, 2021

Memory map comparison

@github-actions
Copy link

github-actions bot commented Sep 7, 2021

Memory map comparison

@maximeborges maximeborges mentioned this pull request Sep 7, 2021
Merged
@adamgreig
Copy link
Member

Could you rebase this now that #612 is merged, please?

@github-actions
Copy link

github-actions bot commented Sep 9, 2021

Memory map comparison

@maximeborges
Copy link
Member Author

maximeborges commented Sep 18, 2021 •
edited
Loading

Could you rebase this now that #612 is merged, please?

This should be good to go.
Should I ping you when things are ready for others PRs to merge or you just don't have much time to look at them but get the notifications? (no pressure :p)

@adamgreig
Copy link
Member

Thanks! I don't mind being pinged but do get the notifications; I've been on holiday the last week but I'm back today so will be going through these last couple of PRs in the next day or two.

adamgreig
adamgreig reviewed Sep 28, 2021
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I just noticed one typo that I'll apply the fix for now.

adamgreig
adamgreig approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@github-actions
Copy link

Memory map comparison

@adamgreig
Copy link
Member

ugh, bors seems to have gotten stuck?

bors cancel

@adamgreig
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 28, 2021

Build succeeded:

@bors bors bot merged commit a72aca8 into stm32-rs:master Sep 28, 2021
bors bot added a commit that referenced this pull request Sep 28, 2021
@bors @maximeborges @adamgreig
Merge #620
d022ba0 
620: [stm32f7] Fix SDMMC registers r=adamgreig a=maximeborges

Following #613, fix fields in SDMMC* for every F7 chips

Co-authored-by: Maxime <contact@maximeborg.es>
Co-authored-by: Adam Greig <adam@adamgreig.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximeborges @adamgreig