stm32wb: ADC -> ADC1 and add ADC_COMMON #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e834817 to
8668d01
Compare
|
Hrm, that memory map comparison is neat, looks like CCR was already there, btu underneath ADC1 itself. I'll try and remove them out. |
As is commonly done, use "ADC1" even when there's only one ADC. This makes it not only more self consistent, (interrupt names were for ADC1) but also more consistent with sibling targets like STM32L4. Also, like the L4, the WB svd is missing the ADC_Common registers. Add them back in, but note that there's less bits in the common registers. Note that CCR _is_ defined, but as part of the core block, so we have to delete it from there as well. Signed-off-by: Karl Palsson <karlp@etactica.com>
8668d01 to
befbfb5
Compare
|
Ok, that's good now. I could easily be conviced to drop the renames of the CH17SEL/CH18SEL, but those names match the ref man, and the L4 implelmentation |
adamgreig
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is commonly done, use "ADC1" even when there's only one ADC. This
makes it not only more self consistent, (interrupt names were for ADC1)
but also more consistent with sibling targets like STM32L4.
Also, like the L4, the WB svd is missing the ADC_Common registers. Add
them back in, but note that there's less bits in the common registers.
Signed-off-by: Karl Palsson karlp@etactica.com