stm32wb: syscfg: fix split sections #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlp
added a commit
to etactica/stm32wb-hal
that referenced
this pull request
Sep 8, 2021
This is likely to be more maintained going forward. Only changes are due to upstream renaming fields in the SVD to be more standard across families, and to more closely match the RefManuals. Depends on either stm32-rs/stm32-rs#624 or stm32-rs/stm32-rs#473 and then a new upstream pac release, so _this_ commit should change to depend on those, but this shows what's needed and how, for preview. Signed-off-by: Karl Palsson <karlp@etactica.com>
adamgreig
previously approved these changes
Sep 8, 2021
|
Merge conflict. |
|
Ah, boo, looks like it conflicts with #623. Could you rebase please? |
Fixes: stm32-rs#473 Fixes the base address, and then for the registers after the split, fixup their addresses manually. Signed-off-by: Karl Palsson <karlp@etactica.com>
c198705 to
32befe7
Compare
|
No problem, rebased. (They both were doing section renames) |
KirmTwinty
pushed a commit
to KirmTwinty/stm32wb-hal
that referenced
this pull request
Dec 6, 2024
This is likely to be more maintained going forward. Only changes are due to upstream renaming fields in the SVD to be more standard across families, and to more closely match the RefManuals. Depends on either stm32-rs/stm32-rs#624 or stm32-rs/stm32-rs#473 and then a new upstream pac release, so _this_ commit should change to depend on those, but this shows what's needed and how, for preview. Signed-off-by: Karl Palsson <karlp@etactica.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #473
Fixes the base address, and then for the registers after the split,
fixup their addresses manually.
Signed-off-by: Karl Palsson karlp@etactica.com
Is there really any need to specifically mark the VREFBUF as "reserved" within the syscfg block as discussed in #473? is that important? the memory map generated looks correct.