STM32L4xx: Add GPIOx ASCR & BRR registers #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardeoin
requested changes
Jan 14, 2022
There was a problem hiding this comment.
Thanks for the PR! Couple of comments:
- The RM describes the BRR / ASCR registers with a series of one-bit fields
BRR0,BRR1, ... and this is the case for all the other GPIO register definitions also. I think this would be preferred instead of a 16-bit field for consistency if nothing else - BRR is also missing on stm32l4x1, stm32l4x2, stm32l412, stm32l4x3. These are parts that don't have ASCR, so it would make sense to split the patch file and apply the BRR section to stm32l4x1.. also
|
@richardeoin Thanks for the feedback. I believe this should address all your points? |
…3 aswell. Add enum variants to both files
3260cf8 to
96a4fea
Compare
richardeoin
previously approved these changes
Jan 16, 2022
richardeoin
approved these changes
Jan 16, 2022
bors bot
added a commit
that referenced
this pull request
Jan 16, 2022
680: STM32L4xx: Add GPIOx ASCR & BRR registers r=richardeoin a=MathiasKoch Also corrects naming on L4x5 ADC `Mult` to `Dual` field, as per the reference manual, and adds prescaler field under ADC_CRR. Fixes #342 Co-authored-by: Mathias <mk@blackbird.online> Co-authored-by: Richard Meadows <richardeoin@gmail.com>
|
Build failed: |
|
Not sure why CI failed. Let's retry bors retry |
|
Enums in common_patches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also corrects naming on L4x5 ADC
MulttoDualfield, as per the reference manual, and adds prescaler field under ADC_CRR.Fixes #342