shorter registernames for stm32l4 devices of the COMP registers + add… #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can simplify this using COMP:
COMP1_CSR:
_strip:
- "COMP1_"
COMP2_CSR:
_strip:
- "COMP2_" |
|
Hi burbull |
|
I have updated the pull request as you recomended.
Tanks a Lot, this ist a way better solution.
…
Am 28.12.2021 in 09:53, Zgarbul Andrey ***@***.***> schrieb:
You can simplify this using _strip:
COMP: COMP1_CSR: _strip: - "COMP1_" COMP2_CSR: _strip: - "COMP2_"
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
adamgreig
previously approved these changes
Jul 3, 2022
|
Merge conflict. |
adamgreig
previously approved these changes
Jul 3, 2022
bors bot
added a commit
that referenced
this pull request
Jul 3, 2022
682: shorter registernames for stm32l4 devices of the COMP registers + add… r=adamgreig a=oldsheep68 …ing the register descriptions Changes in: crates stm32l4x1, crates stm32l4x2, crates stm32l4x3, crates stm32l4x5, crates stm32l4x6 registers of the comparator have been renamed, example: from comp1_en -> en this makes a more generic use in programming possible Furthermore, the description has been added for all comp During this work, I found the following topics, where I do not know, how to address: 1) Reference Manual RM0394: is valid for: STM32L443 and STM32L433; but I had to add the register description in the device descriptors stm32l4x3 of RM0351 2) The device STM32L471 is part of stm32l4x1, but is in RM0351 whereas all other devices are part of RM0394 Co-authored-by: oldsheep68 <oldsheep68@hotmail.com> Co-authored-by: Adam Greig <adam@adamgreig.com>
|
Build failed: |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing the register descriptions
Changes in: crates stm32l4x1, crates stm32l4x2, crates stm32l4x3, crates stm32l4x5, crates stm32l4x6
registers of the comparator have been renamed, example: from comp1_en -> en
this makes a more generic use in programming possible
Furthermore, the description has been added for all comp
During this work, I found the following topics, where I do not know, how to address:
Reference Manual RM0394: is valid for: STM32L443 and STM32L433; but I had to add the register description in the device descriptors stm32l4x3 of RM0351
The device STM32L471 is part of stm32l4x1, but is in RM0351 whereas all other devices are part of RM0394