Update stm32h7 #185
Merged
Update stm32h7 #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, some DAC changes as well. |
|
Thanks for this! I'll finish off the DAC changes, in this case adding new type parameters in the right place can get a bit tricky.. |
|
Hmm, when building the RTIC examples we end up with both cortex-m 0.6 (from RTIC) and cortex-m 0.7 (everything else) in the tree, and the compiler sees types from each version as distinct. Potentially this can be resolved by tweaking the examples |
|
The newer releases of cortex-m 0.6 re-export the types from cortex-m 0.7, so you should be able to just call |
3671b7e to
bd43bcd
Compare
Some changes, mostly to H7B3
* DAC peripheral on rm0433/rm0399 parts is still called "DAC12" to match reference manual naming. We keep this, even though it is now quite confusing considering the existance of two separate DACs on rm0455 parts * Complete the HAL upgrade to support two DACs. We need to add the peripheral as a generic type on the Channel type, because we need different codegen for Cx on DAC2 compared Cx on DAC1. Add the REC type as an associated type for DacExt implementations. * 2nd DAC peripheral on rm0455 parts is actually capable of "autonomous mode" operation (srd/d3), but the D3AMR/SRDAMR register still needs some work in stm32-rs
cebae9a to
77ece78
Compare
|
I see now that stm32 0.6 is not fully forward compatible: rust-embedded/cortex-m#333 |
|
Looks good, I added a little more explanation in the changelog. bors r+ |
richardeoin
added a commit
to richardeoin/stm32h7xx-hal
that referenced
this pull request
Mar 16, 2021
Incorrect since stm32-rs#185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stm32h7 should have a release soon. Preparing for that.